Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-440: SNO IPV4 PXE job for ABI #39907

Merged
merged 1 commit into from Jul 6, 2023
Merged

AGENT-440: SNO IPV4 PXE job for ABI #39907

merged 1 commit into from Jul 6, 2023

Conversation

pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented May 31, 2023 •
edited

Run the SNO IPV4 PXE job only for PRs that touch the agent-specific code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 31, 2023 •
edited by openshift-ci bot

@pawanpinjarkar: This pull request references AGENT-440 which is a valid jira issue.

In response to this:

Run the SNO IPV4 PXE job only for PRs that touch the agent-specific code, on master and release-4.14 branches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe pull-ci-openshift-installer-release-4.14-e2e-agent-sno-ipv4-pxe

@pawanpinjarkar
Copy link
Contributor Author

/cc @bfournie @andfasano @rwsu

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@pawanpinjarkar
Copy link
Contributor Author

/retest

1 similar comment
@pawanpinjarkar
Copy link
Contributor Author

/retest

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[75]: invalid cluster profile "oci-assisted"

If the problem persists, please contact Test Platform.

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[75]: invalid cluster profile "oci-assisted"

If the problem persists, please contact Test Platform.

andfasano
andfasano reviewed Jun 5, 2023
View reviewed changes
ci-operator/config/openshift/installer/openshift-installer-release-4.14.yaml Outdated
cluster_profile: equinix-ocp-metal
env:
DEVSCRIPTS_CONFIG: |
AGENT_E2E_TEST_SCENARIO=SNO_IPV4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully sure that this is required, the CI bot should update the branch jobs accordingly from the master one

@andfasano
Copy link
Contributor

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe

@openshift-ci-robot
Copy link
Contributor

@andfasano, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[75]: invalid cluster profile "oci-assisted"

If the problem persists, please contact Test Platform.

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[75]: invalid cluster profile "oci-assisted"

If the problem persists, please contact Test Platform.

@andfasano
Copy link
Contributor

/pj-rehearse

1 similar comment
@andfasano
Copy link
Contributor

/pj-rehearse

@andfasano andfasano mentioned this pull request Jun 6, 2023
Merged
@andfasano
Copy link
Contributor

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

4 similar comments
@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@andfasano
Copy link
Contributor

/pj-rehearse

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe

2 similar comments
@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe

@andfasano andfasano mentioned this pull request Jun 30, 2023
Merged
@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe

@andfasano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@pawanpinjarkar pawanpinjarkar force-pushed the pxe-boot-abi branch 3 times, most recently from 65fa321 to bb416e9 Compare July 5, 2023 13:01
@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2023 •
edited by openshift-ci bot

@pawanpinjarkar: This pull request references AGENT-440 which is a valid jira issue.

In response to this:

Run the SNO IPV4 PXE job only for PRs that touch the agent-specific code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano
andfasano reviewed Jul 5, 2023
View reviewed changes
ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-ref.yaml Outdated
@@ -1,6 +1,7 @@
ref:
as: baremetalds-devscripts-setup
from: dev-scripts
timeout: 6h0m0s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really required? It could have impacts also on other non-agent jobs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, let's remove it.

@pawanpinjarkar
AGENT-440: SNO IPV4 PXE job for ABI
c4894a0 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe openshift/installer presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andfasano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d012730 into openshift:master Jul 6, 2023
19 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

@pawanpinjarkar: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml

In response to this:

Run the SNO IPV4 PXE job only for PRs that touch the agent-specific code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano andfasano left review comments

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@sadasu sadasu Awaiting requested review from sadasu

@bfournie bfournie Awaiting requested review from bfournie

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@andfasano andfasano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@pawanpinjarkar @openshift-ci-robot @andfasano @openshift-merge-robot