SPLAT-1082: enable OPCT vSphere jobs to install with vSphere external CCM #39923
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rvanderp3: This pull request references SPLAT-1082 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rvanderp3
force-pushed
the
platform-external-tp
branch
from
0865d4d
to
417c18d
Compare
|
/pj-rehearse pull-ci-openshift-installer-release-4.14-e2e-vsphere-external |
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.14-platform-external-vsphere |
rvanderp3
force-pushed
the
platform-external-tp
branch
from
417c18d
to
6ebe611
Compare
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.14-platform-external-vsphere |
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.14-platform-external-vsphere |
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.13-platform-none-vsphere |
openshift-merge-robot
added
the
needs-rebase
|
@rvanderp3, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
rvanderp3
force-pushed
the
platform-external-tp
branch
from
e88f517
to
1dcb735
Compare
openshift-merge-robot
removed
the
needs-rebase
rvanderp3
force-pushed
the
platform-external-tp
branch
2 times, most recently
from
2796d69
to
614ff81
Compare
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.14-platform-external-vsphere |
| @@ -94,10 +94,10 @@ source "${SHARED_DIR}/govc.sh" | |||
| echo "$(date -u --rfc-3339=seconds) - Extend install-config.yaml ..." | |||
|
|
|||
| # install-config for `None` platform type is expected | |||
| declare platform_none="none: {}" | |||
| declare platform_none="${PLATFORM_NONE_TYPE:-none}: {}" | |||
There was a problem hiding this comment.
@rvanderp3 do we need to define the platformName too, as it is expected in the API? I think users will set it in install-config.yaml, instead of patching the infra object.
There was a problem hiding this comment.
yeah, that's a good point. we'll have to add another environment variable for this i think.
There was a problem hiding this comment.
@rvanderp3 in general it looks good to me. I was trying to figure out why the commands from step upi-conf-vsphere-platform-external has duplicated from upi-conf-vsphere-commands.sh, but it seems both generates ignitions into the same script, so seems to block the exiting external needs (which requires to patch the infra object). I think for the future we can reuse it the same as upi-conf-vsphere-platform-none, where the IC is created prior to the upi-conf-vsphere, using some checks like this.
What do you think? |
I'm not sure why much of that logic is duplicated tbh. In looking through that step, though, i think you're right. we should probably just stick with 'none' since the external workflow is making some changes to the manifests. |
rvanderp3
force-pushed
the
platform-external-tp
branch
3 times, most recently
from
2ee7014
to
6fe118f
Compare
|
@rvanderp3, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
rvanderp3
force-pushed
the
platform-external-tp
branch
2 times, most recently
from
3e6806b
to
a75c4b4
Compare
openshift-ci
bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-release-master-nightly-4.14-e2e-vsphere-external-ccm |
|
@rvanderp3: job(s): pull-ci-openshift-release-master-nightly-4.14-e2e-vsphere-external-ccm either don't exist or were not found to be affected, and cannot be rehearsed |
rvanderp3
force-pushed
the
platform-external-tp
branch
from
7646453
to
ff7ba45
Compare
|
@rvanderp3: job(s): pull-ci-openshift-release-master-nightly-4.14-e2e-vsphere-external-ccm either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.14-platform-external-vsphere |
|
this is generally looking good to me, happy to label once we get the a good test signal. |
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.14-platform-external-vsphere |
rvanderp3
force-pushed
the
platform-external-tp
branch
from
ff7ba45
to
150175d
Compare
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.14-platform-external-vsphere |
|
@rvanderp3: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.14-platform-external-vsphere |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtulio, rvanderp3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse |
|
@rvanderp3 would you mind renaming the title and adding, maybe "CCM", to be easily identified in the search? |
rvanderp3
changed the title
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
other platform none workflows are working fine, removing the hold. |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
openshift-merge-robot
merged commit 9277ec9
into
openshift:master
No description provided.