Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-1310: Add retries when waiting for topolvm pods on AWS #40073

Merged

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jun 6, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 6, 2023

@ggiguash: This pull request references USHIFT-1310 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2023
@openshift-ci openshift-ci bot requested review from copejon and pacevedom June 6, 2023 14:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@ggiguash
Copy link
Contributor Author

ggiguash commented Jun 6, 2023

/pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e

@ggiguash
Copy link
Contributor Author

ggiguash commented Jun 6, 2023

/pj-rehearse pull-ci-openshift-microshift-release-4.13-e2e-reboot

@ggiguash
Copy link
Contributor Author

ggiguash commented Jun 6, 2023

/pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

@ggiguash: The label(s) /label rehearsals-ack cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label rehearsals-ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash ggiguash changed the title WIP: USHIFT-1310: Add retries when waiting for topolvm pods on AWS and GPC USHIFT-1310: Add retries when waiting for topolvm pods on AWS and GPC Jun 7, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2023
@ggiguash ggiguash changed the title USHIFT-1310: Add retries when waiting for topolvm pods on AWS and GPC USHIFT-1310: Add retries when waiting for topolvm pods on AWS Jun 7, 2023
@ggiguash
Copy link
Contributor Author

ggiguash commented Jun 7, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 7, 2023
@pmtk
Copy link
Member

pmtk commented Jun 7, 2023

/pj-rehearse more

@ggiguash
Copy link
Contributor Author

ggiguash commented Jun 7, 2023

/pj-rehearse

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 7, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ggiguash: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-release-4.13-e2e-greenboot openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-greenboot-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-loadbalancer-smoke-test openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-loadbalancer-smoke-test-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-microshift-e2e openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-microshift-e2e-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-microshift-e2e openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-microshift-e2e-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-microshift-e2e openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-microshift-e2e-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-e2e-openshift-conformance-reduced openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-e2e-openshift-conformance-reduced openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-openshift-conformance-reduced openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-reboot openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-reboot-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-router-smoke-test openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-router-smoke-test-arm openshift/microshift presubmit Registry content changed
periodic-ci-openshift-microshift-release-4.13-nightly-conformance-serial N/A periodic Registry content changed
periodic-ci-openshift-microshift-release-4.13-nightly-conformance-parallel N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pmtk
Copy link
Member

pmtk commented Jun 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

ggiguash commented Jun 7, 2023

/pj-rehearse abort

@ggiguash
Copy link
Contributor Author

ggiguash commented Jun 7, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

@ggiguash: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/microshift/release-4.13/e2e-openshift-conformance-reduced-arm c663224cb133107a86085377c0b2479d311ff721 link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.13-e2e-openshift-conformance-reduced-arm
ci/rehearse/openshift/microshift/release-4.15/e2e-openshift-conformance-reduced-arm c663224cb133107a86085377c0b2479d311ff721 link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.15-e2e-openshift-conformance-reduced-arm
ci/rehearse/openshift/microshift/main/e2e-openshift-conformance-reduced-arm c663224cb133107a86085377c0b2479d311ff721 link unknown /pj-rehearse pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced-arm
ci/rehearse/openshift/microshift/release-4.15/microshift-e2e-arm 4ddc5f0 link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.15-microshift-e2e-arm
ci/rehearse/openshift/microshift/release-4.14/microshift-e2e 4ddc5f0 link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.14-microshift-e2e
ci/rehearse/openshift/microshift/main/microshift-e2e-arm 4ddc5f0 link unknown /pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 26ca353 into openshift:master Jun 7, 2023
20 of 23 checks passed
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jun 9, 2023
@ggiguash ggiguash deleted the microshift_e2e_retry branch June 20, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants