Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-4214: update ossm to 2.4 #40436

Merged
merged 5 commits into from
Jul 11, 2023
Merged

OSSM-4214: update ossm to 2.4 #40436

merged 5 commits into from
Jul 11, 2023

Conversation

FilipB
Copy link
Contributor

@FilipB FilipB commented Jun 19, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2023 •
edited by openshift-ci bot

@FilipB: This pull request references OSSM-4214 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dgn and liswang89 June 19, 2023 08:11
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@FilipB
Copy link
Contributor Author

FilipB commented Jun 19, 2023

/pj-rehearse

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@FilipB FilipB mentioned this pull request Jun 19, 2023
Merged
@FilipB
Copy link
Contributor Author

FilipB commented Jun 20, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jun 20, 2023

/pj-rehearse

2 similar comments
@FilipB
Copy link
Contributor Author

FilipB commented Jun 20, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jun 21, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@FilipB: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maistra-maistra-test-tool-main-servicemesh-ocp4.14-lp-interop-images maistra/maistra-test-tool presubmit Ci-operator config changed
periodic-ci-maistra-maistra-test-tool-main-servicemesh-ocp4.14-lp-interop-servicemesh-interop-aws N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@FilipB
Copy link
Contributor Author

FilipB commented Jun 21, 2023

/pj-rehearse

10 similar comments
@FilipB
Copy link
Contributor Author

FilipB commented Jun 21, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jun 21, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jun 22, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jun 22, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jun 28, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jul 4, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jul 5, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jul 10, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jul 10, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jul 11, 2023

/pj-rehearse

@FilipB
Copy link
Contributor Author

FilipB commented Jul 11, 2023

All tests are green

@FilipB
Copy link
Contributor Author

FilipB commented Jul 11, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 11, 2023
calebevans
calebevans approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@calebevans calebevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebevans, FilipB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

@FilipB: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f11e3b3 into openshift:master Jul 11, 2023
21 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

@FilipB: Updated the ci-operator-main-configs configmap in namespace ci at cluster app.ci using the following files:

  • key maistra-maistra-test-tool-main__servicemesh-ocp4.14-lp-interop.yaml using file ci-operator/config/maistra/maistra-test-tool/maistra-maistra-test-tool-main__servicemesh-ocp4.14-lp-interop.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebevans calebevans calebevans approved these changes

@dgn dgn Awaiting requested review from dgn

@liswang89 liswang89 Awaiting requested review from liswang89

Assignees

@calebevans calebevans

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@FilipB @openshift-ci-robot @calebevans @openshift-merge-robot