Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the operator based command arguments #40709

Merged

Conversation

xueqzhan
Copy link
Contributor

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@xueqzhan: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.15-k8s-e2e-gcp-serial openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.14-k8s-e2e-gcp-serial openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.13-k8s-e2e-gcp-serial openshift/kubernetes presubmit Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-ovirt-sdn N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.13-e2e-azure-ovn-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-upgrade-from-stable-4.12-e2e-vsphere-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-vsphere-ovn-csi N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.12-e2e-azure-sdn N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-gcp-ovn-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.13-e2e-aws-sdn N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-vsphere-ovn-upi N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-azure-upgrade-cnv N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-local-gateway N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-vsphere-ovn-techpreview N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-gcp-ovn-fips N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-sdn-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-gcp-sdn-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-multi N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-sdn-techpreview-serial N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-ovn-dualstack N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-vsphere-ovn-techpreview-serial N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-azure-ovn-etcd-scaling N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-aws-csi N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-workers-rhel8 N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-ovn-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-vsphere-ovn-serial N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-libvirt-cert-rotation N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.13-e2e-aws-sdn-multitenant N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-sdn-techpreview N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-crun N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-sdn-upgrade N/A periodic Registry content changed

A total of 391 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@xueqzhan
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

@openshift-ci openshift-ci bot requested review from deepsm007 and neisw June 27, 2023 15:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@xueqzhan
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 27, 2023
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0a8584d into openshift:master Jun 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants