Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-675: Add gather chain #40768

Merged

Conversation

pawanpinjarkar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 28, 2023

@pawanpinjarkar: This pull request references AGENT-675 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar
Copy link
Contributor Author

/cc @andfasano

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@@ -3,7 +3,7 @@ chain:
steps:
- ref: baremetalds-devscripts-gather
- ref: agent-gather
# - chain: gather
- chain: gather
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I guess it could be better to ref directly the baremetalds-ipi-post chain, after the agent-gather

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That causes duplicate name error as seen here

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/agent-post: chain/baremetalds-ipi-post: duplicate name: baremetalds-devscripts-gather, chain/agent-post: duplicate name: baremetalds-packet-teardown, workflow/agent-e2e-compact-ipv4: chain/agent-post: chain/baremetalds-ipi-post: duplicate name: baremetalds-devscripts-gather, workflow/agent-e2e-compact-ipv4: chain/agent-post: duplicate name: baremetalds-packet-teardown, workflow/agent-e2e-generic: chain/agent-post: chain/baremetalds-ipi-post: duplicate name: baremetalds-devscripts-gather, workflow/agent-e2e-generic: chain/agent-post: duplicate name: baremetalds-packet-teardown]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: Chain agent-post contains non-existent reference baremetalds-ipi-post
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/agent-post: duplicate name: baremetalds-packet-teardown, workflow/agent-e2e-compact-ipv4: chain/agent-post: duplicate name: baremetalds-packet-teardown, workflow/agent-e2e-generic: chain/agent-post: duplicate name: baremetalds-packet-teardown]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@@ -1,9 +1,7 @@
chain:
as: agent-post
steps:
- ref: baremetalds-devscripts-gather
- chain: baremetalds-ipi-post
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor point, but I was used to see the custom steps (agent-gather) before the common ones

Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact openshift-metal3/dev-scripts presubmit Registry content changed
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-sno-ipv6 openshift-metal3/dev-scripts presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-master-e2e-agent-compact-ipv4 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.15-e2e-agent-compact-ipv4 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.14-e2e-agent-compact-ipv4 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.13-e2e-agent-compact-ipv4 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.12-e2e-agent-compact-ipv4 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-master-e2e-agent-sno-ipv6 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-master-e2e-agent-ha-dualstack openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.15-e2e-agent-sno-ipv6 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.15-e2e-agent-ha-dualstack openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.14-e2e-agent-sno-ipv6 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.14-e2e-agent-ha-dualstack openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.13-e2e-agent-sno-ipv6 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.13-e2e-agent-ha-dualstack openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.12-e2e-agent-sno-ipv6 openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-installer-agent-release-4.12-e2e-agent-ha-dualstack openshift/assisted-installer-agent presubmit Registry content changed
pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.15-e2e-agent-compact-ipv4 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.14-e2e-agent-compact-ipv4 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.13-e2e-agent-compact-ipv4 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.12-e2e-agent-compact-ipv4 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-master-e2e-agent-sno-ipv6 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-master-e2e-agent-ha-dualstack openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.15-e2e-agent-sno-ipv6 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.15-e2e-agent-ha-dualstack openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.14-e2e-agent-sno-ipv6 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.14-e2e-agent-ha-dualstack openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.13-e2e-agent-sno-ipv6 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.13-e2e-agent-ha-dualstack openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.12-e2e-agent-sno-ipv6 openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-assisted-service-release-4.12-e2e-agent-ha-dualstack openshift/assisted-service presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-main-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.15-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.14-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed

A total of 70 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@andfasano
Copy link
Contributor

I don't know why the gather-must-gather chain failed for some agent-installer-utils repo jobs (but in other cases passed). This should be investigated, otherwise it could impact the success ratio of the future release jobs.

/retest

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/agent-installer-utils/release-4.15/e2e-agent-ha-dualstack 85c99b2 link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-release-4.15-e2e-agent-ha-dualstack
ci/rehearse/openshift/agent-installer-utils/main/e2e-agent-sno-ipv6 85c99b2 link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-main-e2e-agent-sno-ipv6
ci/rehearse/openshift/agent-installer-utils/main/e2e-agent-ha-dualstack 85c99b2 link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-main-e2e-agent-ha-dualstack
ci/rehearse/openshift/agent-installer-utils/release-4.15/e2e-agent-sno-ipv6 85c99b2 link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-release-4.15-e2e-agent-sno-ipv6
ci/rehearse/openshift/assisted-service/master/e2e-agent-ha-dualstack 85c99b2 link unknown /pj-rehearse pull-ci-openshift-assisted-service-master-e2e-agent-ha-dualstack
ci/rehearse/openshift/assisted-service/master/e2e-agent-sno-ipv6 85c99b2 link unknown /pj-rehearse pull-ci-openshift-assisted-service-master-e2e-agent-sno-ipv6
ci/rehearse/openshift/assisted-service/release-4.13/e2e-agent-compact-ipv4 85c99b2 link unknown /pj-rehearse pull-ci-openshift-assisted-service-release-4.13-e2e-agent-compact-ipv4
ci/rehearse/openshift/assisted-service/release-4.14/e2e-agent-sno-ipv6 85c99b2 link unknown /pj-rehearse pull-ci-openshift-assisted-service-release-4.14-e2e-agent-sno-ipv6
ci/rehearse/openshift/assisted-service/release-4.15/e2e-agent-ha-dualstack 85c99b2 link unknown /pj-rehearse pull-ci-openshift-assisted-service-release-4.15-e2e-agent-ha-dualstack
ci/rehearse/openshift/assisted-service/master/e2e-agent-compact-ipv4 85c99b2 link unknown /pj-rehearse pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
ci/rehearse/openshift/assisted-service/release-4.15/e2e-agent-sno-ipv6 85c99b2 link unknown /pj-rehearse pull-ci-openshift-assisted-service-release-4.15-e2e-agent-sno-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pawanpinjarkar
Copy link
Contributor Author

/retest

@pawanpinjarkar
Copy link
Contributor Author

I don't know why the gather-must-gather chain failed for some agent-installer-utils repo jobs (but in other cases passed). This should be investigated, otherwise it could impact the success ratio of the future release jobs.

/retest

The failures look to be related to some of the cluster operators that were still progressing.

@pawanpinjarkar
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: job(s): ci/rehearse/openshift/agent-installer-utils/main/e2e-agent-sno-ipv6, ci/rehearse/openshift/assisted-service/master/e2e-agent-compact-ipv4, ci/rehearse/openshift/assisted-service/master/e2e-agent-sno-ipv6, ci/rehearse/openshift/assisted-service/release-4.14/e2e-agent-sno-ipv6 either don't exist or were not found to be affected, and cannot be rehearsed

@andfasano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 90e8edc into openshift:master Jul 13, 2023
22 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants