-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-675: Add gather chain #40768
AGENT-675: Add gather chain #40768
Conversation
@pawanpinjarkar: This pull request references AGENT-675 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @andfasano |
@@ -3,7 +3,7 @@ chain: | |||
steps: | |||
- ref: baremetalds-devscripts-gather | |||
- ref: agent-gather | |||
# - chain: gather | |||
- chain: gather |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point I guess it could be better to ref directly the baremetalds-ipi-post chain, after the agent-gather
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That causes duplicate name error as seen here
@pawanpinjarkar,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
377202a
to
fbdec08
Compare
@pawanpinjarkar,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
fbdec08
to
004ade4
Compare
@pawanpinjarkar,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
004ade4
to
dfdcbf8
Compare
@@ -1,9 +1,7 @@ | |||
chain: | |||
as: agent-post | |||
steps: | |||
- ref: baremetalds-devscripts-gather | |||
- chain: baremetalds-ipi-post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor point, but I was used to see the custom steps (agent-gather) before the common ones
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
dfdcbf8
to
85c99b2
Compare
[REHEARSALNOTIFIER]
A total of 70 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse |
I don't know why the gather-must-gather chain failed for some agent-installer-utils repo jobs (but in other cases passed). This should be investigated, otherwise it could impact the success ratio of the future release jobs. /retest |
/pj-rehearse |
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
The failures look to be related to some of the cluster operators that were still progressing. |
/retest |
@pawanpinjarkar: job(s): ci/rehearse/openshift/agent-installer-utils/main/e2e-agent-sno-ipv6, ci/rehearse/openshift/assisted-service/master/e2e-agent-compact-ipv4, ci/rehearse/openshift/assisted-service/master/e2e-agent-sno-ipv6, ci/rehearse/openshift/assisted-service/release-4.14/e2e-agent-sno-ipv6 either don't exist or were not found to be affected, and cannot be rehearsed |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse ack |
90e8edc
into
openshift:master
No description provided.