Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-368: Add a periodic version of the STS e2e tests #41065

Closed

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Jul 7, 2023

This test will be called weekly.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2023

@bentito: This pull request references CCO-368 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2023

@bentito: This pull request references CCO-368 which is a valid jira issue.

In response to this:

This test will be called weekly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dlom and suhanime July 7, 2023 16:45
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 7, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bentito
Once this PR has been reviewed and has the lgtm label, please assign lleshchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@bentito: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-cloud-credential-operator-master-e2e-aws-manual-oidc-periodic N/A periodic Periodic changed
periodic-ci-openshift-cloud-credential-operator-release-4.15-e2e-aws-manual-oidc-periodic N/A periodic Periodic changed
periodic-ci-openshift-cloud-credential-operator-release-4.14-e2e-aws-manual-oidc-periodic N/A periodic Periodic changed
periodic-ci-openshift-cloud-credential-operator-release-4.13-e2e-aws-manual-oidc-periodic N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bentito
Copy link
Contributor Author

bentito commented Jul 7, 2023

/assign @abutcher @jstuever

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

@bentito: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bentito
Copy link
Contributor Author

bentito commented Jul 7, 2023

@abutcher @jstuever does this seem right for causing the make test-e2e-sts target to get called weekly? And weekly seems like the right interval for this given the PR frequency for CCO?

@suhanime
Copy link
Contributor

@bentito I have added the make target to the periodic test in 40385 (Thanks for pointing it out). I think we can close this PR in favour of 40385.

@bentito
Copy link
Contributor Author

bentito commented Jul 10, 2023

@bentito I have added the make target to the periodic test in 40385 (Thanks for pointing it out). I think we can close this PR in favour of 40385.

Oh yeah definitely. Thanks @suhanime . Closing.

@bentito bentito closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
5 participants