Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent-installer-utils: use rhel-9-golang-1.20 as a base image #41142

Closed
wants to merge 1 commit into from
Closed

agent-installer-utils: use rhel-9-golang-1.20 as a base image #41142

wants to merge 1 commit into from

Conversation

andfasano
Copy link
Contributor

@andfasano andfasano commented Jul 11, 2023 •
edited

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@openshift-ci openshift-ci bot requested review from bfournie and zaneb July 11, 2023 10:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@andfasano
Copy link
Contributor Author

/pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023 •
edited

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/agent-installer-utils/main/e2e-agent-ha-dualstack 3b68675a2cc8b2109b3b1218fe237a089ac9abfa link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-main-e2e-agent-ha-dualstack
ci/rehearse/openshift/agent-installer-utils/main/e2e-agent-sno-ipv6 3b68675a2cc8b2109b3b1218fe237a089ac9abfa link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-main-e2e-agent-sno-ipv6
ci/rehearse/openshift/agent-installer-utils/main/images 3b68675a2cc8b2109b3b1218fe237a089ac9abfa link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-main-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andfasano
Copy link
Contributor Author

/retest-required

@andfasano andfasano changed the title [WIP] agent-installer-utils: use rhel-9-golang-1.20 as a base image agent-installer-utils: use rhel-9-golang-1.20 as a base image Jul 17, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2023
@andfasano
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@andfasano andfasano mentioned this pull request Jul 17, 2023
Closed
@andfasano
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-agent-installer-utils-main-e2e-agent-compact-ipv4

1 similar comment
@andfasano
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-agent-installer-utils-main-e2e-agent-compact-ipv4

@andfasano
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-agent-installer-utils-main-e2e-agent-compact-ipv4

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@andfasano: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-agent-installer-utils-main-e2e-agent-bad-dns openshift/agent-installer-utils presubmit Ci-operator config changed
pull-ci-openshift-agent-installer-utils-main-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Ci-operator config changed
pull-ci-openshift-agent-installer-utils-main-e2e-agent-ha-dualstack openshift/agent-installer-utils presubmit Ci-operator config changed
pull-ci-openshift-agent-installer-utils-main-e2e-agent-sno-ipv6 openshift/agent-installer-utils presubmit Ci-operator config changed
pull-ci-openshift-agent-installer-utils-main-gofmt openshift/agent-installer-utils presubmit Ci-operator config changed
pull-ci-openshift-agent-installer-utils-main-govet openshift/agent-installer-utils presubmit Ci-operator config changed
pull-ci-openshift-agent-installer-utils-main-images openshift/agent-installer-utils presubmit Ci-operator config changed
pull-ci-openshift-agent-installer-utils-main-unit openshift/agent-installer-utils presubmit Ci-operator config changed
pull-ci-openshift-agent-installer-utils-main-verify-vendor openshift/agent-installer-utils presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andfasano
Copy link
Contributor Author

Will be addressed in https://issues.redhat.com/browse/CORS-2750

@andfasano andfasano closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfournie bfournie Awaiting requested review from bfournie

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
2 participants
@andfasano @openshift-ci-robot