Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-657: aws-localzones - dropping feature gate for phase2 #41366

Merged

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jul 18, 2023

Dropping the feature gate configuration from the Local Zone jobs for outstanding PRs openshift/installer#7137 .

The Feature Gate requirement will also be removed from installer when this PR is merged.

ref https://redhat-internal.slack.com/archives/C68TNFWA2/p1688392414050629

/assign @patrickdillon

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2023

@mtulio: This pull request references SPLAT-657 which is a valid jira issue.

In response to this:

Dropping the feature gate configuration from the Local Zone jobs for outstanding PRs openshift/installer#7137 .

The Feature Gate requirement will also be removed from installer when this PR is merged.

/assign @patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2023

@mtulio: This pull request references SPLAT-657 which is a valid jira issue.

In response to this:

Dropping the feature gate configuration from the Local Zone jobs for outstanding PRs openshift/installer#7137 .

The Feature Gate requirement will also be removed from installer when this PR is merged.

ref https://redhat-internal.slack.com/archives/C68TNFWA2/p1688392414050629

/assign @patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-release-4.14-e2e-aws-ovn-localzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.15-e2e-aws-ovn-localzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-localzones openshift/installer presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio
Copy link
Contributor Author

mtulio commented Jul 18, 2023

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 18, 2023
@openshift-ci openshift-ci bot requested review from andfasano and r4f4 July 18, 2023 12:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit c0bd672 into openshift:master Jul 18, 2023
16 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@mtulio: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.14.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.14.yaml
  • ci-operator-4.15-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.15.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.15.yaml

In response to this:

Dropping the feature gate configuration from the Local Zone jobs for outstanding PRs openshift/installer#7137 .

The Feature Gate requirement will also be removed from installer when this PR is merged.

ref https://redhat-internal.slack.com/archives/C68TNFWA2/p1688392414050629

/assign @patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio deleted the splat-657-aws-lz-drop-fg branch July 18, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants