Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1244: Add azure-manual-oidc workload to cluster ingress operator #41502

Merged
merged 1 commit into from Jul 24, 2023

Conversation

dlom
Copy link
Contributor

@dlom dlom commented Jul 20, 2023

This PR enables e2e verification of the changes necessary to complete NE-1244 (openshift/cluster-ingress-operator#929)

/cc @abutcher @Miciah

@openshift-ci openshift-ci bot requested review from abutcher and Miciah July 20, 2023 17:35
@dlom dlom changed the title Add azure-manual-oidc workload to cluster ingress operator NE-1244: Add azure-manual-oidc workload to cluster ingress operator Jul 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 20, 2023

@dlom: This pull request references NE-1244 which is a valid jira issue.

In response to this:

This PR enables e2e verification of the changes necessary to complete NE-1244

/cc @abutcher @Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 20, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dlom: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-manual-oidc openshift/cluster-ingress-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 20, 2023

@dlom: This pull request references NE-1244 which is a valid jira issue.

In response to this:

This PR enables e2e verification of the changes necessary to complete NE-1244 (openshift/cluster-ingress-operator#929)

/cc @abutcher @Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dlom
Copy link
Contributor Author

dlom commented Jul 20, 2023

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-manual-oidc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@dlom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-ingress-operator/master/e2e-azure-manual-oidc fdb0e67 link unknown /pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-manual-oidc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abutcher
Copy link
Member

Looks like the test failed in the IPI deprovision but was a successful install + test otherwise.

level=info msg=Install complete!

@Miciah
Copy link
Contributor

Miciah commented Jul 21, 2023

Notwithstahding the deprovisioning failure, is the job ready to merge?

From what I can tell,
/lgtm

/hold
in case we need to fix the deprovisioning issue before adding the job.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@abutcher
Copy link
Member

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@abutcher
Copy link
Member

The deprovisioning failure has no other history and will not be related to AZWI. I think we continue with this merge and open a low priority bug for the deprovisioning failure so that folks can keep track of it if it happens again but my take is that its just a blip / lag on the Azure side that would be rare and unavoidable.

@abutcher
Copy link
Member

@dlom
Copy link
Contributor Author

dlom commented Jul 24, 2023

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit f657845 into openshift:master Jul 24, 2023
18 of 19 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

@dlom: Updated the following 2 configmaps:

  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-ingress-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-ingress-operator-master.yaml using file ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml

In response to this:

This PR enables e2e verification of the changes necessary to complete NE-1244 (openshift/cluster-ingress-operator#929)

/cc @abutcher @Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants