New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-1244: Add azure-manual-oidc workload to cluster ingress operator #41502
Conversation
@dlom: This pull request references NE-1244 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@dlom: This pull request references NE-1244 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-manual-oidc |
@dlom: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Looks like the test failed in the IPI deprovision but was a successful install + test otherwise.
|
Notwithstahding the deprovisioning failure, is the job ready to merge? From what I can tell, /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
The deprovisioning failure has no other history and will not be related to AZWI. I think we continue with this merge and open a low priority bug for the deprovisioning failure so that folks can keep track of it if it happens again but my take is that its just a blip / lag on the Azure side that would be rare and unavoidable. |
/pj-rehearse skip |
f657845
into
openshift:master
@dlom: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR enables e2e verification of the changes necessary to complete NE-1244 (openshift/cluster-ingress-operator#929)
/cc @abutcher @Miciah