-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-16629: Increase gateway migration rollout for OVNK-IC #42165
OCPBUGS-16629: Increase gateway migration rollout for OVNK-IC #42165
Conversation
@tssurya: This pull request references Jira Issue OCPBUGS-16629, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@tssurya: This pull request references Jira Issue OCPBUGS-16629, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@tssurya: This pull request references Jira Issue OCPBUGS-16629, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
I think from the job itself we should be able to measure the time for OVNK components versus K8s rollout perhaps and go with that? You should also be able to do this manually - the migration switch I mean and see what's happening there.. We anyways need to do this I guess for IC. But I am OK to wait if you think this will help your investigations... |
/pj-rehearse |
/hold cancel This is going to affect all jobs, not just master. There has definitely been a regression so adding this extra timeout is just ignoring that for now. I have a bug assigned to me that we can use to track this regression. It's possible we will just ignore it, but I need to point out that this is not fixing anything just allowing more time for whatever started taking |
/hold |
# FIXME: Increasing timeout to 15minutes for OVNK IC deployments (original value was 360seconds) | ||
# See https://issues.redhat.com/browse/OCPBUGS-16629 for details | ||
timeout 900s oc rollout status ds/ovnkube-node -n openshift-ovn-kubernetes | ||
timeout 900s oc rollout status ds/ovnkube-master -n openshift-ovn-kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ timeout 900s oc rollout status ds/ovnkube-master -n openshift-ovn-kubernetes
Error from server (NotFound): daemonsets.apps "ovnkube-master" not found
this is not ovnkube-master
any more in IC world, its ovnkube-control-plane
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also its not daemonset anymore,
its deployment
bb30436
to
9bd90d1
Compare
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
9bd90d1
to
4e40324
Compare
[REHEARSALNOTIFIER]
A total of 43 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse |
/retest |
1 similar comment
/retest |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-shared-to-local-gateway-mode-migration |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-local-to-shared-gateway-mode-migration |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-shared-to-local-gateway-mode-migration |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.15-e2e-aws-ovn-local-to-shared-gateway-mode-migration |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-e2e-aws-ovn-local-to-shared-gateway-mode-migration |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.15-e2e-aws-ovn-shared-to-local-gateway-mode-migration |
/hold cancel |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-shared-to-local-gateway-mode-migration |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-local-to-shared-gateway-mode-migration |
nonIC: |
@tssurya: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/pj-rehearse ack |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jluhrsen, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5e7ec83
into
openshift:master
@tssurya: Jira Issue OCPBUGS-16629: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-16629 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
/cc @anuragthehatter @jluhrsen @trozet