Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 4.12 oldest supported creds request #42753

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Update 4.12 oldest supported creds request #42753

merged 1 commit into from
Aug 28, 2023

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Aug 28, 2023 •
edited

Update the oldest-supported-credentials-request to 4.12.29 to pick up the addition on route53:ListTagsForResources.

Related to https://issues.redhat.com//browse/OCPBUGS-18193

@ncdc
Update 4.12 oldest supported creds request
9a1f6ed 
Update the oldest-supported-credentials-request to 4.12.29 to pick up
the addition on route53:ListTagsForResources.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc ncdc changed the title Update 4.12 oldest supported creds request OCPBUGS-18193: Update 4.12 oldest supported creds request Aug 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 28, 2023
@openshift-ci-robot
Copy link
Contributor

@ncdc: This pull request references Jira Issue OCPBUGS-18193, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update the oldest-supported-credentials-request to 4.12.29 to pick up the addition on route53:ListTagsForResources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ncdc: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-single-node-workers N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-upgrade-from-stable-4.10-e2e-aws-sdn-upgrade-paused N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-proxy N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-upgrade-from-stable-4.11-e2e-metal-ipi-sdn-bm-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-gcp-ovn-upi N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-ovirt-sdn N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-azurestack-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-ibmcloud-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-driver-toolkit N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-telco5g-cnftests N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-azure-sdn N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-telco5g-ptp N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-ovn-dualstack N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-vsphere-ovn-etcd-scaling N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-gcp-libvirt-cert-rotation N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-upgrade-from-stable-4.11-e2e-metal-ipi-upgrade-ovn-ipv6 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-single-node N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-vsphere-ovn-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-serial-ovn-dualstack N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-sdn-serial-ipv4 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-azure-ovn-upi N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-single-node-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-local-gateway N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-upgrade-from-stable-4.11-e2e-aws-upgrade-ovn-single-node N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-fips-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-vsphere-ovn-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-ovn-ipv4 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-gcp-ovn-rt N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ovn-single-node-live-iso N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-ovn-workers-rhel8 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-gcp-ovn-fips N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-credentials-request-freeze N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-gcp-sdn-fips-serial N/A periodic Ci-operator config changed

A total of 82 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from neisw and stbenjam August 28, 2023 17:14
@ncdc
Copy link
Contributor Author

ncdc commented Aug 28, 2023

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.12-credentials-request-freeze

wking
wking approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

@ncdc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncdc
Copy link
Contributor Author

ncdc commented Aug 28, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 28, 2023
@ncdc ncdc changed the title OCPBUGS-18193: Update 4.12 oldest supported creds request Update 4.12 oldest supported creds request Aug 28, 2023
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 28, 2023
@openshift-ci-robot
Copy link
Contributor

@ncdc: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Update the oldest-supported-credentials-request to 4.12.29 to pick up the addition on route53:ListTagsForResources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit dbbcce3 into openshift:master Aug 28, 2023
16 checks passed
@ncdc ncdc deleted the bump-4.12-oldest-creds branch August 28, 2023 17:32
prb112 pushed a commit to prb112/openshift-release that referenced this pull request Sep 12, 2023
@ncdc @prb112
Update 4.12 oldest supported creds request (openshift#42753)
52c0f25 
Update the oldest-supported-credentials-request to 4.12.29 to pick up
the addition on route53:ListTagsForResources.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@neisw neisw Awaiting requested review from neisw

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@ncdc @openshift-ci-robot @wking @openshift-merge-robot