Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-2537: [4.14 - 4.15] gcp userLabels & userTags #42819

Merged
merged 1 commit into from Oct 31, 2023

Conversation

jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Aug 30, 2023

  • the 4.14 epic - CORS-2455 User defined labels for GCP Resources(TP)
  • add workflow cucushift-installer-rehearse-gcp-ipi-user-labels-tags-filestore-csi and the provision chain
  • add step ipi-conf-gcp-user-labels-tags to insert userLabels and userTags settings into install-config.yaml
  • add step gcp-provision-user-tags-serviceaccount to enable the IAM service-account for userTags testing
  • update step ipi-install-install and ipi-deprovision-deprovision to use the above IAM service-account
  • add step cucushift-installer-check-gcp-user-labels as post-installation check of the userLabels of general resources
  • add periodic tests in 4.14 & 4.15 multi nightly, i.e. gcp-ipi-user-labels-tags-filestore-csi-tp-amd-f28-destructive and gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2023
@jianli-wei jianli-wei marked this pull request as draft August 30, 2023 09:44
@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: failed to load registry file /var/tmp/gitrepo3221905215/ci-operator/step-registry/ipi/conf/gcp/user-labels-tags/ipi-conf-gcp-user-labels-tags-ref.yaml: reference ipi-conf-gcp-user-lables-tags has invalid command file path; command should be set to ipi-conf-gcp-user-labels-tags-commands (with an optional extension like .sh)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: Chain cucushift-installer-rehearse-gcp-ipi-user-lables-tags-provision contains non-existent reference ipi-conf-gcp-user-lables-tags
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei jianli-wei changed the title [WIP][4.14] gcp userLabels & userTags CORS-2537: [WIP][4.14] gcp userLabels & userTags Aug 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 30, 2023

@jianli-wei: This pull request references CORS-2537 which is a valid jira issue.

In response to this:

WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 30, 2023
@jianli-wei
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo3262286367/ci-operator/step-registry/cucushift/installer/rehearse/gcp/ipi/user-lables-tags/cucushift-installer-rehearse-gcp-ipi-user-labels-tags-workflow.metadata.json has incorrect prefix. Prefix should be cucushift-installer-rehearse-gcp-ipi-user-lables-tags
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei
Copy link
Contributor Author

/retest-required

@jianli-wei
Copy link
Contributor Author

/retest-required

@jianli-wei
Copy link
Contributor Author

/retest-required

@jianli-wei
Copy link
Contributor Author

/retest-required

1 similar comment
@jianli-wei
Copy link
Contributor Author

/retest-required

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@jianli-wei
Copy link
Contributor Author

/retest-required

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@jianli-wei
Copy link
Contributor Author

/retest-required

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@jianli-wei jianli-wei force-pushed the gcp-labels branch 3 times, most recently from 801d7c9 to cfc827e Compare October 31, 2023 02:26
@jianli-wei jianli-wei force-pushed the gcp-labels branch 2 times, most recently from 3cdfddd to b01d29a Compare October 31, 2023 03:02
@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-debug

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 31, 2023

@jianli-wei: This pull request references CORS-2537 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.15." or "openshift-4.15.", but it targets "openshift-4.14" instead.

In response to this:

  • the 4.14 epic - CORS-2455 User defined labels for GCP Resources(TP)
  • add workflow cucushift-installer-rehearse-gcp-ipi-user-labels-tags-filestore-csi and the provision chain
  • add step ipi-conf-gcp-user-labels-tags to insert userLabels and userTags settings into install-config.yaml
  • add step gcp-provision-user-tags-serviceaccount to enable the IAM service-account for userTags testing
  • update step ipi-install-install and ipi-deprovision-deprovision to use the above IAM service-account
  • add step cucushift-installer-check-gcp-user-labels as post-installation check of the userLabels of general resources
  • add periodic tests in 4.14 & 4.15 multi nightly, i.e. gcp-ipi-user-labels-tags-filestore-csi-tp-amd-f28-destructive and gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@jianli-wei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-amd-f28-destructive 7d0fe983d5b55d0c33348ac4596267129786b66f link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-amd-f28-destructive
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14 7d0fe983d5b55d0c33348ac4596267129786b66f link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14
ci/build-farm/build09-dry 2f75848389124ae392d38783a9d06954d9ce591b link true /test build09-dry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianli-wei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-policy-controller-master-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.16-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.15-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.14-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.13-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.12-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.11-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.10-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.9-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.8-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.7-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.6-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.5-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.4-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.3-e2e-aws openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-master-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.16-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.15-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.14-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.13-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.12-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.11-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.10-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.9-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.8-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.7-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.6-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.5-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.4-e2e-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-cluster-policy-controller-release-4.3-e2e-aws-upgrade openshift/cluster-policy-controller presubmit Registry content changed
pull-ci-openshift-psap-special-resource-operator-release-4.6-e2e-aws openshift-psap/special-resource-operator presubmit Registry content changed
pull-ci-openshift-psap-special-resource-operator-release-4.5-e2e-aws openshift-psap/special-resource-operator presubmit Registry content changed
pull-ci-openshift-psap-special-resource-operator-release-4.6-e2e-aws-upgrade openshift-psap/special-resource-operator presubmit Registry content changed
pull-ci-openshift-psap-special-resource-operator-release-4.5-e2e-aws-upgrade openshift-psap/special-resource-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-4.3-e2e-aws openshift/cluster-version-operator presubmit Registry content changed

A total of 14566 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianlinliu
Copy link
Contributor

/lgtm

@jianlinliu
Copy link
Contributor

cc @liangxia to review.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@jianlinliu
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 31, 2023
@liangxia
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, jianlinliu, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@jianlinliu
Copy link
Contributor

/test all

@openshift-ci openshift-ci bot merged commit 2543ce4 into openshift:master Oct 31, 2023
18 checks passed
@jianli-wei jianli-wei deleted the gcp-labels branch October 31, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
8 participants