Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry auth for quay.io/openshifttest #42822

Merged
merged 1 commit into from Oct 17, 2023

Conversation

lwan-wanglin
Copy link
Contributor

@lwan-wanglin lwan-wanglin commented Aug 30, 2023

refer to https://issues.redhat.com/browse/MIXEDARCH-318

  • add auth for quay.io/openshifttest
  • for disconnected test, instead of adding one more proxy registry for quay.io/openshifttest, using a personal account of quay.io as auth to forward images from both quay.io/openshifttest and quay.io/openshift-qe-optional-operators, not just a robot accout auth of openshift-qe-optional-operators
  • already updated account info to bitwarden and vault

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-gcp-ipi-xpn-fips-f14

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-mtu-localzone-fips-f14

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-mtu-localzone-fips-f14

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-gcp-ipi-disconnected-private-f28-destructive

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-fips-f14

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-c2s-ipi-disconnected-private-fips-f28-destructive

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-fips-f14

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.11-arm64-nightly-aws-ipi-disconnected-sts-efs-f28

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-sts-ep-fips-f14

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-openshift-logging-5.7-aws-ipi-ovn-ipsec-amd-mixarch-f7

@lwan-wanglin
Copy link
Contributor Author

/test build09-dry

@lwan-wanglin
Copy link
Contributor Author

lwan-wanglin commented Oct 12, 2023

@aleskandro @anpingli @jianzhangbjz could you help review the pr? thanks!

@anpingli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@anpingli
Copy link
Contributor

By the way, there isn't function to mirror openshift-test images in enable-qe-catalog steps. I think you have to define new steps if needs

@lwan-wanglin
Copy link
Contributor Author

lwan-wanglin commented Oct 12, 2023

By the way, there isn't function to mirror openshift-test images in enable-qe-catalog steps. I think you have to define new steps if needs

thanks, I checked we already have a step to mirror openshifttest images for disconnect test: mirror-images-qe-test-images, and I need to add auth there too.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@lwan-wanglin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-release-4.16-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-release-4.15-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-release-4.14-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-master-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.16-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.15-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.14-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-master-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.16-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.15-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.14-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-operator-master-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-operator-release-4.16-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-operator-release-4.15-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-operator-release-4.14-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.15-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.14-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-azure-disk-csi-driver-operator-master-e2e-azure-csi-extended openshift/azure-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-disk-csi-driver-operator-release-4.16-e2e-azure-csi-extended openshift/azure-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-disk-csi-driver-operator-release-4.15-e2e-azure-csi-extended openshift/azure-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-disk-csi-driver-operator-release-4.14-e2e-azure-csi-extended openshift/azure-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-master-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-release-4.16-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-release-4.15-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-release-4.14-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-ibm-vpc-node-label-updater-master-e2e-ibmcloud-csi-extended openshift/ibm-vpc-node-label-updater presubmit Registry content changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.16-e2e-ibmcloud-csi-extended openshift/ibm-vpc-node-label-updater presubmit Registry content changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.15-e2e-ibmcloud-csi-extended openshift/ibm-vpc-node-label-updater presubmit Registry content changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.14-e2e-ibmcloud-csi-extended openshift/ibm-vpc-node-label-updater presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-master-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.16-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.15-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver-operator presubmit Registry content changed

A total of 2990 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@lwan-wanglin
Copy link
Contributor Author

@aleskandro @anpingli @jianzhangbjz PTAL again, thanks!

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-c2s-ipi-disconnected-private-fips-f14

@jianzhangbjz
Copy link
Contributor

jianzhangbjz commented Oct 13, 2023

why it influnces the pr merging?

Because we didn't test these changes introduced by this PR in fact for C2S.

@jianzhangbjz
Copy link
Contributor

It works well on my local, interesting, maybe something is wrong with the ec2-54-204-84-68.compute-1.amazonaws.com:5000 mirror registry.

[cloud-user@preserve-olm-env2 client]$ ./oc version 
Client Version: 4.15.0-0.nightly-2023-10-09-101435
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

[cloud-user@preserve-olm-env2 client]$ ./oc image mirror --insecure=true --skip-missing=true --skip-verification=true --keep-manifest-list=true --filter-by-os='.*' quay.io/openshifttest/ociimage:multiarch localhost:5000/olmqe/ociimage2:multiarch2
localhost:5000/
  olmqe/ociimage2
    blobs:
      quay.io/openshifttest/ociimage sha256:85f81ee96f1868efa8c596e3bd232bf82852e105575b38d9818f72524c76d7a2 579B
      quay.io/openshifttest/ociimage sha256:9946b8ff3f01e57a5d0a135a98fb553df2bf3568636f7e38d4e83b525d7c360b 579B
      quay.io/openshifttest/ociimage sha256:fc875386057e8d1f478f11b00cfdad723ec49845b4aacd8c4b2588aba4ef715f 579B
      quay.io/openshifttest/ociimage sha256:c44eec791f01552c64717a96c22b49ca00173da9c9ba5cf6dfd7e166ef278ffc 581B
      quay.io/openshifttest/ociimage sha256:6e0d958327d1db0518e775eef6abbaad484f4974e41af5c1d911141017bfe512 592B
      quay.io/openshifttest/ociimage sha256:9a37fcf4311d4028ef67d425ed29f2996e3e1666d3d45c6e258b3e023ce9c5c9 594B
      quay.io/openshifttest/ociimage sha256:ce2875e009aa96cc7e23a042bc2350668c62b20a3523c9fd6f2f34aa1f95d59d 25.67MiB
      quay.io/openshifttest/ociimage sha256:3dfa8236861920dda2ce67cef8af1fa06ae6cb669612efbbf4a2c177a1c1e451 25.94MiB
      quay.io/openshifttest/ociimage sha256:166e0294b8df947d819744f38e21281ed5f29a2a3b19d191deee511cbfb0e473 27.67MiB
      quay.io/openshifttest/ociimage sha256:54b8fda3c9de3a40f0891ce200de55fc92e825315021192957f1bfe3fc807d7d 28.97MiB
      quay.io/openshifttest/ociimage sha256:ef8f08deb2ebee9069392096f64a14c620b5694921860dc066d66f8418e72b44 29.02MiB
      quay.io/openshifttest/ociimage sha256:555144941f8c5a1b06838e83133d0a853781a2b7dd8a15e72b4a185bcd689e98 34.49MiB
    manifests:
      sha256:1c1876cd529c6032521ae4788c29c1bf8a7f00968ac4a4058c068d25bebf94b2
      sha256:5e4ed9b51a61727bc600494d538cbed109162047e0ca6a14229fda1f152ae1b6
      sha256:97923994fdc1c968eed6bdcb64be8e70d5356b88cfab0481cb6b73a4849361b7
      sha256:a34bd409e8ea9186852711c4ec983f05799a927ab31c98bbb67b5653fe0ede3b
      sha256:bd0be70569d8b18321d7d3648d51925e22865df760c5379b69762f302cacd30d
      sha256:dbf17b01a9051a96c86888ea44b6ea4358a3c1693e2d49b46d6841b4208555ad
      sha256:d58e3e003ddec723dd14f72164beaa609d24c5e5e366579e23bc8b34b9a58324 -> multiarch2
  stats: shared=0 unique=12 size=171.8MiB ratio=1.00

phase 0:
  localhost:5000 olmqe/ociimage2 blobs=12 mounts=0 manifests=7 shared=0

info: Planning completed in 1.36s
uploading: localhost:5000/olmqe/ociimage2 sha256:54b8fda3c9de3a40f0891ce200de55fc92e825315021192957f1bfe3fc807d7d 28.97MiB
uploading: localhost:5000/olmqe/ociimage2 sha256:ce2875e009aa96cc7e23a042bc2350668c62b20a3523c9fd6f2f34aa1f95d59d 25.67MiB
uploading: localhost:5000/olmqe/ociimage2 sha256:166e0294b8df947d819744f38e21281ed5f29a2a3b19d191deee511cbfb0e473 27.67MiB
uploading: localhost:5000/olmqe/ociimage2 sha256:555144941f8c5a1b06838e83133d0a853781a2b7dd8a15e72b4a185bcd689e98 34.49MiB
uploading: localhost:5000/olmqe/ociimage2 sha256:ef8f08deb2ebee9069392096f64a14c620b5694921860dc066d66f8418e72b44 29.02MiB
uploading: localhost:5000/olmqe/ociimage2 sha256:3dfa8236861920dda2ce67cef8af1fa06ae6cb669612efbbf4a2c177a1c1e451 25.94MiB
sha256:bd0be70569d8b18321d7d3648d51925e22865df760c5379b69762f302cacd30d localhost:5000/olmqe/ociimage2
sha256:a34bd409e8ea9186852711c4ec983f05799a927ab31c98bbb67b5653fe0ede3b localhost:5000/olmqe/ociimage2
sha256:97923994fdc1c968eed6bdcb64be8e70d5356b88cfab0481cb6b73a4849361b7 localhost:5000/olmqe/ociimage2
sha256:5e4ed9b51a61727bc600494d538cbed109162047e0ca6a14229fda1f152ae1b6 localhost:5000/olmqe/ociimage2
sha256:dbf17b01a9051a96c86888ea44b6ea4358a3c1693e2d49b46d6841b4208555ad localhost:5000/olmqe/ociimage2
sha256:1c1876cd529c6032521ae4788c29c1bf8a7f00968ac4a4058c068d25bebf94b2 localhost:5000/olmqe/ociimage2
sha256:d58e3e003ddec723dd14f72164beaa609d24c5e5e366579e23bc8b34b9a58324 localhost:5000/olmqe/ociimage2:multiarch2
info: Mirroring completed in 2.47s (72.87MB/s)

@jianzhangbjz
Copy link
Contributor

Hi @anpingli @yunjiang29 do we have any changes for the ec2-54-204-84-68.compute-1.amazonaws.com:5000 mirror registry recently? Thanks!

@jianlinliu
Copy link
Contributor

Hi @anpingli @yunjiang29 do we have any changes for the ec2-54-204-84-68.compute-1.amazonaws.com:5000 mirror registry recently? Thanks!

I guess no, we did not change on registry service for a long time, here is the configuration codes for registry service, is there any difference with your local? And the configuration code is alomsot the same as flexy-template codes, if you need to debug the issue, you can launch an env using flexy-template.

BTW, for the error:

error: unable to parse image quay.io/openshifttest/hypershift-client:latest: unknown image manifest of type *ocischema.DeserializedImageIndex from manifest sha256:a07d17732ec22101d33717db10c43fb9c6bdb952011827a8db02a699c3e19729

Is it related with oc version in prow ci?

@lwan-wanglin
Copy link
Contributor Author

I am launching a jenkins job to check for 4.15.

@jianzhangbjz
Copy link
Contributor

jianzhangbjz commented Oct 13, 2023

Is it related with oc version in prow ci?

Yes, good catch! The oc of ocp/4.15:cli doesn't work, details:

[cloud-user@preserve-olm-env2 jian]$ oc image extract registry.ci.openshift.org/ocp/4.15:cli  --path /usr/bin/oc:. --confirm
[cloud-user@preserve-olm-env2 jian]$ sudo chmod 777 oc
[cloud-user@preserve-olm-env2 jian]$ 
[cloud-user@preserve-olm-env2 jian]$ ./oc version 
Client Version: v4.2.0-alpha.0-2030-g0307852
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
[cloud-user@preserve-olm-env2 jian]$ ./oc image mirror --insecure=true --skip-missing=true --skip-verification=true --keep-manifest-list=true --filter-by-os='.*' quay.io/openshifttest/ociimage:multiarch localhost:5000/olmqe/ociimage3:multiarch
localhost:5000/
  olmqe/ociimage3
    error: the manifest type *ocischema.DeserializedImageIndex is not supported
    manifests:
      sha256:d58e3e003ddec723dd14f72164beaa609d24c5e5e366579e23bc8b34b9a58324 -> multiarch
  stats: shared=0 unique=0 size=0B

error: the manifest type *ocischema.DeserializedImageIndex is not supported
error: an error occurred during planning

But, the latest 4.15 oc works well as shown above #42822 (comment).

[cloud-user@preserve-olm-env2 client]$ ./oc version 
Client Version: 4.15.0-0.nightly-2023-10-09-101435
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

So, we should update the oc of the ocp/4.15:cli.

@jianlinliu
Copy link
Contributor

we should update the oc of the ocp/4.15:cli.

Maybe there is some delay update on oc in prow ci or some out-of-date config for ocp/4.15:cli, I guess 4.14 should not hit such issue.

@jianzhangbjz
Copy link
Contributor

Maybe there is some delay update on oc in prow ci or some out-of-date config for ocp/4.15:cli, I guess 4.14 should not hit such issue.

Actually, the oc of ocp/4.15:cli is the latest, which is built from the latest commits: openshift/oc@0307852. The old 4.15 oc works well.

                    "created": "2023-10-12T23:06:08.279786979Z",
                    "created_by": "/bin/sh -c #(nop) LABEL \"io.openshift.build.name\"=\"cli-amd64\" \"io.openshift.build.namespace\"=\"ci-op-37527gwf\" \"io.openshift.build.commit.author\"=\"\" \"io.openshift.build.commit.date\"=\"\" \"io.openshift.build.commit.id\"=\"03078525c97d612c2070081d0e9f322f946360f4\" \"io.openshift.build.commit.message\"=\"\" \"io.openshift.build.commit.ref\"=\"master\" \"io.openshift.build.name\"=\"\" \"io.openshift.build.namespace\"=\"\" \"io.openshift.build.source-context-dir\"=\"\" \"io.openshift.build.source-location\"=\"https://github.com/openshift/oc\" \"io.openshift.ci.from.base\"=\"sha256:d7a2588527405101eeb1578a0e97e465ec83b0b927b71cf689703554e81cb585\" \"vcs-ref\"=\"03078525c97d612c2070081d0e9f322f946360f4\" \"vcs-type\"=\"git\" \"vcs-url\"=\"https://github.com/openshift/oc\"",

And, I reported a bug there: https://issues.redhat.com/browse/OCPBUGS-20528

@lwan-wanglin
Copy link
Contributor Author

the 4.13 c2s job step mirror-images-qe-test-images passed.

@ardaguclu
Copy link
Member

I think, this commit openshift/oc@70b0588 caused the issue which aligned with the problem timeline

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

@lwan-wanglin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-openshift-logging-5.7-aws-ipi-ovn-ipsec-amd-mixarch-f7 24e1373c1a4161344a00284fb1b388290f59d806 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-openshift-logging-5.7-aws-ipi-ovn-ipsec-amd-mixarch-f7
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-sts-ep-fips-f14 24e1373c1a4161344a00284fb1b388290f59d806 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-sts-ep-fips-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-mtu-localzone-fips-f14 358f37d link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-mtu-localzone-fips-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-c2s-ipi-disconnected-private-fips-f14 358f37d link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-c2s-ipi-disconnected-private-fips-f14

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lwan-wanglin
Copy link
Contributor Author

lwan-wanglin commented Oct 16, 2023

@LiangquanLi930 n there is also a modification releated to hypershift, PTAL! thanks!

@LiangquanLi930
Copy link
Member

looks good, rehearse job to double check

@LiangquanLi930
Copy link
Member

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-ovn-hypershift-fips-mgmt-f14

@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-c2s-ipi-disconnected-private-fips-f28-destructive

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@jianlinliu
Copy link
Contributor

/lgtm

@heliubj18
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anpingli, heliubj18, jianlinliu, jianzhangbjz, lwan-wanglin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@lwan-wanglin
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 17, 2023
@openshift-ci openshift-ci bot merged commit 8b6a21f into openshift:master Oct 17, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
8 participants