Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include habana based workbench image build from ocp-ci #43461

Merged
merged 1 commit into from
Sep 26, 2023
Merged

include habana based workbench image build from ocp-ci #43461

merged 1 commit into from
Sep 26, 2023

Conversation

harshad16
Copy link
Member

include habana based workbench image build from ocp-ci

Related-to: opendatahub-io/notebooks#214
opendatahub-io/notebooks#96

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@harshad16
Copy link
Member Author

pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-habana-jupyter-ubi8-python-3-8-pr-image-mirror

@harshad16
Copy link
Member Author

/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-habana-jupyter-ubi8-python-3-8-pr-image-mirror

@harshad16 harshad16 force-pushed the habana-wb branch 2 times, most recently from ea0e9f3 to 8db7f2e Compare September 20, 2023 20:11
@harshad16
Copy link
Member Author

/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-habana-jupyter-ubi8-python-3-8-pr-image-mirror

1 similar comment
@atheo89
Copy link
Contributor

atheo89 commented Sep 21, 2023

/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-habana-jupyter-ubi8-python-3-8-pr-image-mirror

atheo89
atheo89 suggested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshad16! Only a small change is needed.

@harshad16 harshad16 force-pushed the habana-wb branch 2 times, most recently from f8c1c6a to 66751b9 Compare September 21, 2023 15:47
@openshift-ci-robot
Copy link
Contributor

@harshad16, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase repo client
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@harshad16
Copy link
Member Author

/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-habana-jupyter-ubi8-python-3-8-pr-image-mirror

@openshift-ci-robot
Copy link
Contributor

@harshad16, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase repo client

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023 •
edited
Loading

@harshad16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/opendatahub-io/notebooks/main/notebook-habana-jupyter-ubi8-python-3-8-pr-image-mirror 8db7f2eec2f1843414606ab117a6b83f6b773e22 link unknown /pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-habana-jupyter-ubi8-python-3-8-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harshad16 harshad16 force-pushed the habana-wb branch 2 times, most recently from ba545d8 to d89bda5 Compare September 26, 2023 02:49
@harshad16
Copy link
Member Author

/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi8-python-3-8-pr-image-mirror

@harshad16
include habana based workbench image build from ocp-ci
e2e0a78 
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@harshad16: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-notebooks-main-habana-notebooks-e2e-tests opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-11-0-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-9-0-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-images opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-jupyter-datascience-anaconda-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-codeserver-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi8-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-tf-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-rstudio-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-datascience-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-minimal-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-pytorch-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-trustyai-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-rstudio-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebooks-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-cuda-tensorflow-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-cuda-tensorflow-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-datascience-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-datascience-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed

A total of 38 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@atheo89
Copy link
Contributor

atheo89 commented Sep 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4392f4d into openshift:master Sep 26, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 atheo89 requested changes

@rkpattnaik780 rkpattnaik780 Awaiting requested review from rkpattnaik780

Assignees

@atheo89 atheo89

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@harshad16 @atheo89 @openshift-ci-robot @openshift-merge-robot