Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINC-1053: Add community 4.15 periodic with slack alerting #43528

Merged
merged 1 commit into from Sep 26, 2023
Merged

WINC-1053: Add community 4.15 periodic with slack alerting #43528

merged 1 commit into from Sep 26, 2023

Conversation

mansikulkarni96
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2023 •
edited by openshift-ci bot

@mansikulkarni96: This pull request references WINC-1053 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
aravindhp
aravindhp suggested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @mansikulkarni96

...s-machine-config-operator/openshift-windows-machine-config-operator-community-4.15__okd.yaml Outdated
@@ -0,0 +1,68 @@
base_images:
openshift_release_golang-1.19:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be openshift_release_golang-1.20 given that is the input below?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
alinaryan
alinaryan reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@alinaryan alinaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this,
Should we also make a 4.14 periodic?

...hine-config-operator/openshift-windows-machine-config-operator-community-4.15-periodics.yaml Outdated
name: periodic-ci-openshift-windows-machine-config-operator-community-4.15-okd-aws-e2e-operator
reporter_config:
slack:
channel: '#forum-winc'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#forum-ocp-winc
And that reminds me that it should have been changed for the other branches too

aravindhp
aravindhp suggested changes Sep 19, 2023
View reviewed changes
...s-machine-config-operator/openshift-windows-machine-config-operator-community-4.15__okd.yaml Outdated
Comment on lines 43 to 54
- as: lint
commands: make lint
container:
from: src
- as: build
commands: make build
container:
from: src
- as: unit
commands: make unit
container:
from: src
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we don't need these given there are no PRs opened and no presubmit tests. Not sure why they are present in other community operator configs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had them when we did community backports, but not needed anymore.

alinaryan
alinaryan reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@alinaryan alinaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just a nit typo in commit message.
podmman->podman

@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@mansikulkarni96
wmco: Add community 4.15 periodic with slack alerting
ded16ca 
This commit adds a new community-4.15 okd aws-e2e-operator
periodic test. The job runs daily at midnight and sends failed
job alerts to #forum-winc to warn the team not to use the test's
bundle manifests in the next community WMCO release
to avoid broken community releases.

Updated community-4.15 config and ran:
'make update CONTAINER_ENGINE=podman'
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mansikulkarni96: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-windows-machine-config-operator-community-4.15-okd-images openshift/windows-machine-config-operator presubmit Presubmit changed
periodic-ci-openshift-windows-machine-config-operator-community-4.15-okd-aws-e2e-operator N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mansikulkarni96: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-windows-machine-config-operator-community-4.15-okd-images openshift/windows-machine-config-operator presubmit Presubmit changed
periodic-ci-openshift-windows-machine-config-operator-community-4.15-okd-aws-e2e-operator N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2023
@alinaryan
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alinaryan, aravindhp, jrvaldes, mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mansikulkarni96 mansikulkarni96 marked this pull request as ready for review September 26, 2023 17:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2023
@mansikulkarni96
Copy link
Member Author

/rehearsals-ack

@mansikulkarni96
Copy link
Member Author

/pj-rehearse

@mansikulkarni96
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit cafed03 into openshift:master Sep 26, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinaryan alinaryan Awaiting requested review from alinaryan

@aravindhp aravindhp Awaiting requested review from aravindhp

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@aravindhp aravindhp

@alinaryan alinaryan

@jrvaldes jrvaldes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
6 participants
@mansikulkarni96 @openshift-ci-robot @jrvaldes @alinaryan @aravindhp @openshift-merge-robot