Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Adding install-only blocking jobs for ppc64le and s390x release controllers #43689

Closed
wants to merge 1 commit into from
Closed

WIP - Adding install-only blocking jobs for ppc64le and s390x release controllers #43689

wants to merge 1 commit into from

Conversation

tvardema
Copy link
Contributor

Currently we only have informing jobs for ppc64le and s390x, but the multiarch team would like to have at minimum install-only behavior as a blocking job for any GA'd or upcoming release (currently 4.12 through 4.15).

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

@tvardema, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase repo client
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2023
@tvardema tvardema force-pushed the install-only-periodic-blocking-jobs branch from e67c379 to fc5206c Compare September 25, 2023 20:03
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2023
@tvardema tvardema force-pushed the install-only-periodic-blocking-jobs branch from fc5206c to 31d3083 Compare September 25, 2023 21:21
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2023
@tvardema tvardema force-pushed the install-only-periodic-blocking-jobs branch from 31d3083 to 23e414b Compare September 28, 2023 17:23
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2023
jaypoulz
jaypoulz approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@jaypoulz jaypoulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but the auto-generated release controller config being disabled confuses me.

@jaypoulz
Copy link
Contributor

/approve

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@tvardema tvardema closed this Sep 29, 2023
@tvardema tvardema force-pushed the install-only-periodic-blocking-jobs branch from 23e414b to 0000203 Compare September 29, 2023 16:23
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 29, 2023
@tvardema tvardema reopened this Sep 29, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaypoulz, tvardema
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaypoulz, tvardema
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023 •
edited

@tvardema: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/build-farm/build09-dry 31d3083859f4ce39e98dab0a87989115554528ab link true /test build09-dry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tvardema tvardema force-pushed the install-only-periodic-blocking-jobs branch from c1b1ce8 to ac598c9 Compare September 29, 2023 17:06
@Prashanth684
Copy link
Contributor

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.13-ocp-e2e-install-only-ovn-remote-libvirt-ppc64le

@tvardema
Adding install-only blocking jobs for ppc64le and s390x release contr…
ba02bcc 
…ollers

Currently we only have informing jobs for ppc64le and s390x, but the multiarch team would
like to have at minimum install-only behavior as a blocking job for any GA'd or upcoming
release (currently 4.12 through 4.15).
@tvardema tvardema force-pushed the install-only-periodic-blocking-jobs branch from ac598c9 to ba02bcc Compare September 29, 2023 19:40
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@tvardema: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-master-nightly-4.13-ocp-e2e-install-only-ovn-remote-libvirt-s390x N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-install-only-ovn-remote-libvirt-s390x N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-install-only-ovn-remote-libvirt-ppc64le N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-e2e-install-only-ovn-remote-libvirt-s390x N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.13-ocp-e2e-install-only-ovn-remote-libvirt-ppc64le N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-install-only-ovn-remote-libvirt-s390x N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-install-only-ovn-remote-libvirt-ppc64le N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-e2e-install-only-ovn-remote-libvirt-ppc64le N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tvardema
Copy link
Contributor Author

After talking with the test platform team, this direction is no longer the ideal path. Closing.

@tvardema tvardema closed this Oct 13, 2023
@tvardema tvardema deleted the install-only-periodic-blocking-jobs branch February 27, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypoulz jaypoulz jaypoulz approved these changes

@alkleinrh alkleinrh Awaiting requested review from alkleinrh

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@jaypoulz jaypoulz

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
5 participants
@tvardema @openshift-ci-robot @jaypoulz @Prashanth684 @openshift-merge-robot