Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image-mirroring: Drop driver-toolkit from OKD 4.15 #43816

Merged
merged 1 commit into from
Oct 10, 2023
Merged

image-mirroring: Drop driver-toolkit from OKD 4.15 #43816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion core-services/image-mirroring/openshift/mapping_origin_4_15
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ registry.ci.openshift.org/origin/4.15:descheduler quay.io/openshift/origin-desch
registry.ci.openshift.org/origin/4.15:docker-builder quay.io/openshift/origin-docker-builder:4.15 quay.io/openshift/origin-docker-builder:4.15.0 quay.io/openshift/origin-docker-builder:latest
registry.ci.openshift.org/origin/4.15:docker-registry quay.io/openshift/origin-docker-registry:4.15 quay.io/openshift/origin-docker-registry:4.15.0 quay.io/openshift/origin-docker-registry:latest
registry.ci.openshift.org/origin/4.15:dpu-network-operator quay.io/openshift/origin-dpu-network-operator:4.15 quay.io/openshift/origin-dpu-network-operator:4.15.0 quay.io/openshift/origin-dpu-network-operator:latest
registry.ci.openshift.org/origin/4.15:driver-toolkit quay.io/openshift/origin-driver-toolkit:4.15 quay.io/openshift/origin-driver-toolkit:4.15.0 quay.io/openshift/origin-driver-toolkit:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is using those images?
DTK's customers are usually getting the image using oc adm release info ... --image-for driver-toolkit and getting an image from quay.io/openshift-release-dev/...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this PR, we need to make sure that OKD's users running oc adm release info ... --image-for driver-toolkit won't get those images. If this is the case then we shouldn't remove them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customers shouldn't be using any OKD images unless they specifically want to do that. OKD won't have the driver-toolkit going forward, unless OKD-variant specific builds of that image are set up.

registry.ci.openshift.org/origin/4.15:driver-toolkit-tests quay.io/openshift/origin-driver-toolkit-tests:4.15 quay.io/openshift/origin-driver-toolkit-tests:4.15.0 quay.io/openshift/origin-driver-toolkit-tests:latest
registry.ci.openshift.org/origin/4.15:egress-dns-proxy quay.io/openshift/origin-egress-dns-proxy:4.15 quay.io/openshift/origin-egress-dns-proxy:4.15.0 quay.io/openshift/origin-egress-dns-proxy:latest
registry.ci.openshift.org/origin/4.15:egress-http-proxy quay.io/openshift/origin-egress-http-proxy:4.15 quay.io/openshift/origin-egress-http-proxy:4.15.0 quay.io/openshift/origin-egress-http-proxy:latest
Expand Down
6 changes: 4 additions & 2 deletions core-services/release-controller/_releases/release-ocp-4.15-ci.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
"machine-os-images",
"windows-machine-config-bootstrapper-tests",
"windows-machine-config-operator-bundle",
"windows-machine-config-operator-test"
"windows-machine-config-operator-test",
"driver-toolkit"
]
}
},
Expand Down Expand Up @@ -87,7 +88,8 @@
"machine-os-images",
"windows-machine-config-bootstrapper-tests",
"windows-machine-config-operator-bundle",
"windows-machine-config-operator-test"
"windows-machine-config-operator-test",
"driver-toolkit"
]
}
},
Expand Down