-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image-mirroring: Drop driver-toolkit
from OKD 4.{13,14}
#43957
image-mirroring: Drop driver-toolkit
from OKD 4.{13,14}
#43957
Conversation
[REHEARSALNOTIFIER] |
@LorbusChris: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -128,7 +128,6 @@ registry.ci.openshift.org/origin/4.14:descheduler quay.io/openshift/origin-desch | |||
registry.ci.openshift.org/origin/4.14:docker-builder quay.io/openshift/origin-docker-builder:4.14 quay.io/openshift/origin-docker-builder:4.14.0 | |||
registry.ci.openshift.org/origin/4.14:docker-registry quay.io/openshift/origin-docker-registry:4.14 quay.io/openshift/origin-docker-registry:4.14.0 | |||
registry.ci.openshift.org/origin/4.14:dpu-network-operator quay.io/openshift/origin-dpu-network-operator:4.14 quay.io/openshift/origin-dpu-network-operator:4.14.0 | |||
registry.ci.openshift.org/origin/4.14:driver-toolkit quay.io/openshift/origin-driver-toolkit:4.14 quay.io/openshift/origin-driver-toolkit:4.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we care about older versions? Can't we just keep machine-os-content for older version of OCP and only remove it in newer versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
machine-os-content is not touched here. This change removes an OCP CI image that has been leaking into OKD releases (driver-toolkit).
/lgtm |
/assign @jupierce |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jupierce, LorbusChris, ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@LorbusChris: Updated the
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.