Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-3777: Update builder image - NodeJS v14 to v16 #44053

Conversation

cyril-ui-developer
Copy link
Contributor

This change is intended to update CI mapping for quay.io/coreos/tectonic-console-builder image from v25 to v26.
See the console repo PR for update NodeJS v14 to v16 changes.

/assign @jhadvig

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2023

@cyril-ui-developer: This pull request references CONSOLE-3777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This change is intended to update CI mapping for quay.io/coreos/tectonic-console-builder image from v25 to v26.
See the console repo PR for update NodeJS v14 to v16 changes.

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@openshift-ci openshift-ci bot requested a review from jmguzik October 6, 2023 15:59
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 6, 2023
@openshift-ci openshift-ci bot requested a review from smg247 October 6, 2023 15:59
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2023

@cyril-ui-developer: This pull request references CONSOLE-3777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This change is intended to update CI mapping for quay.io/coreos/tectonic-console-builder image from v25 to v26.
See the console repo PR for update NodeJS v14 to v16 changes.

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -108,7 +108,7 @@ quay.io/kiali/kiali-cypress-tests:v1.65 registry.ci.openshift.org/ci/kiali-cypre
quay.io/redhat_msi/managed-services-integration-tests:latest registry.ci.openshift.org/ci/managed-services-integration-tests:latest
quay.io/rh_integration/xpaas-qe:7.11.x-openjdk1.8_local registry.ci.openshift.org/ci/xpaas-qe:7.11.x-openjdk1.8_local
quay.io/rh_integration/xpaas-qe:7.12.x-openjdk1.8_local registry.ci.openshift.org/ci/xpaas-qe:7.12.x-openjdk1.8_local
quay.io/coreos/tectonic-console-builder:v25 registry.ci.openshift.org/ci/tectonic-console-builder:v25
quay.io/coreos/tectonic-console-builder:v26 registry.ci.openshift.org/ci/tectonic-console-builder:v26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we will be still using the v25 image version for 4.14 release of console, we need to add the image as a new entry rather then updating the one we will keep using.

@cyril-ui-developer cyril-ui-developer force-pushed the update-mapping-ci-tectonic-console-builder-image branch from 714d0f1 to 2a835fc Compare October 9, 2023 16:14
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@cyril-ui-developer: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cyril-ui-developer cyril-ui-developer changed the title [WIP][DO-NOT-MERGE]CONSOLE-3777: Update builder image - NodeJS v14 to v16 CONSOLE-3777: Update builder image - NodeJS v14 to v16 Oct 9, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2023

@cyril-ui-developer: This pull request references CONSOLE-3777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This change is intended to update CI mapping for quay.io/coreos/tectonic-console-builder image from v25 to v26.
See the console repo PR for update NodeJS v14 to v16 changes.

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/retest

@smg247
Copy link
Member

smg247 commented Oct 10, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 496eb4b into openshift:master Oct 10, 2023
8 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@cyril-ui-developer: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_supplemental_ci_images_ci using file core-services/image-mirroring/supplemental-ci-images/mapping_supplemental_ci_images_ci

In response to this:

This change is intended to update CI mapping for quay.io/coreos/tectonic-console-builder image from v25 to v26.
See the console repo PR for update NodeJS v14 to v16 changes.

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants