Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring SNYK for csi-driver-shared-resource-* #44557

Conversation

coreydaley
Copy link
Member

@coreydaley coreydaley commented Oct 18, 2023

It is expected that all of the security tests will fail.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@coreydaley: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-driver-shared-resource-master-security openshift/csi-driver-shared-resource presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-release-4.11-security openshift/csi-driver-shared-resource presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-release-4.12-security openshift/csi-driver-shared-resource presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-release-4.13-security openshift/csi-driver-shared-resource presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-release-4.14-security openshift/csi-driver-shared-resource presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-release-4.15-security openshift/csi-driver-shared-resource presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-release-4.16-security openshift/csi-driver-shared-resource presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-operator-master-security openshift/csi-driver-shared-resource-operator presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-operator-release-4.11-security openshift/csi-driver-shared-resource-operator presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-operator-release-4.12-security openshift/csi-driver-shared-resource-operator presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-operator-release-4.13-security openshift/csi-driver-shared-resource-operator presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-operator-release-4.14-security openshift/csi-driver-shared-resource-operator presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-operator-release-4.15-security openshift/csi-driver-shared-resource-operator presubmit Presubmit changed
pull-ci-openshift-csi-driver-shared-resource-operator-release-4.16-security openshift/csi-driver-shared-resource-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@coreydaley
Copy link
Member Author

/pj-rehearse max

@coreydaley
Copy link
Member Author

/assign @gabemontero
it is ok that all of the security tests fail, we will fix them in the individual repositories at some point and then set the test to required

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coreydaley
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@coreydaley: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/csi-driver-shared-resource/release-4.15/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-release-4.15-security
ci/rehearse/openshift/csi-driver-shared-resource-operator/release-4.14/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-operator-release-4.14-security
ci/rehearse/openshift/csi-driver-shared-resource/release-4.11/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-release-4.11-security
ci/rehearse/openshift/csi-driver-shared-resource/release-4.12/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-release-4.12-security
ci/rehearse/openshift/csi-driver-shared-resource-operator/release-4.16/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-operator-release-4.16-security
ci/rehearse/openshift/csi-driver-shared-resource-operator/release-4.11/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-operator-release-4.11-security
ci/rehearse/openshift/csi-driver-shared-resource-operator/release-4.12/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-operator-release-4.12-security
ci/rehearse/openshift/csi-driver-shared-resource/release-4.13/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-release-4.13-security
ci/rehearse/openshift/csi-driver-shared-resource-operator/release-4.15/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-operator-release-4.15-security
ci/rehearse/openshift/csi-driver-shared-resource-operator/release-4.13/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-operator-release-4.13-security
ci/rehearse/openshift/csi-driver-shared-resource/release-4.16/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-release-4.16-security
ci/rehearse/openshift/csi-driver-shared-resource/master/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-master-security
ci/rehearse/openshift/csi-driver-shared-resource-operator/master/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-operator-master-security
ci/rehearse/openshift/csi-driver-shared-resource/release-4.14/security 584fd56 link unknown /pj-rehearse pull-ci-openshift-csi-driver-shared-resource-release-4.14-security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit a081adb into openshift:master Oct 19, 2023
16 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants