Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22169: fix: update tuned script bootloader args #44616

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

eggfoobar
Copy link
Contributor

updating args to resolve extra reboot issue when tuned is applied

updating args to resolve extra reboot issue when tuned is applied

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

@eggfoobar: This pull request references Jira Issue OCPBUGS-22169, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

updating args to resolve extra reboot issue when tuned is applied

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@eggfoobar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-master-e2e-gcp-ovn-rt-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.16-e2e-gcp-ovn-rt-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.15-e2e-gcp-ovn-rt-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.14-e2e-gcp-ovn-rt-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.13-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.12-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.11-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.8-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.7-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-gcp-ovn-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.10-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.15-e2e-gcp-ovn-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.9-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.6-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade-test N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.11-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-gcp-ovn-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-ovn-rt N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eggfoobar
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade

@openshift-ci openshift-ci bot requested review from dirgim and jsztuka October 19, 2023 21:03
@eggfoobar
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade

@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 20, 2023
@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

/pj-rehearse periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade

@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

/pj-rehearse periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-rt-upgrade

@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

/pj-rehearse periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-ovn-rt-upgrade

@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

/pj-rehearse periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-rt-upgrade

@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

The tests are failing due to infra issues. After manual testing (4.14->4.15 upgrade), I can say
/lgtm
I believe we probably do not need any extra checks for 4.9 (TuneD shipped with NTO)->4.10 (FDP TuneD with NTO). 4.9 is out of support and the 4.9->4.10 upgrade job is informing, not blocking.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 20, 2023
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Jira Issue OCPBUGS-22169, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/origin/release-4.14/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-origin-release-4.14-e2e-gcp-ovn-rt-upgrade
ci/rehearse/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/machine-config-operator/release-4.16/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-release-4.16-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/origin/release-4.13/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-origin-release-4.13-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/machine-config-operator/release-4.15/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-release-4.15-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/machine-config-operator/master/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/origin/release-4.15/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-origin-release-4.15-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/origin/master/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/origin/release-4.12/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-origin-release-4.12-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/machine-config-operator/release-4.14/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-gcp-ovn-rt-upgrade
ci/rehearse/openshift/origin/release-4.16/e2e-gcp-ovn-rt-upgrade 0e2cd57 link unknown /pj-rehearse pull-ci-openshift-origin-release-4.16-e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neisw
Copy link
Contributor

neisw commented Oct 20, 2023

@eggfoobar - we need to get this in for the 4.14 payloads. Are you ready for this to merge?

@DennisPeriquet
Copy link
Contributor

/pj-rehearse ack

@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

/approve

@jmencak
Copy link
Contributor

jmencak commented Oct 20, 2023

looks like I'm not an approval @ffromani , can we have an approval?

@neisw
Copy link
Contributor

neisw commented Oct 20, 2023

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@ffromani
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, ffromani, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit faa5494 into openshift:master Oct 20, 2023
14 of 25 checks passed
@openshift-ci-robot
Copy link
Contributor

@eggfoobar: Jira Issue OCPBUGS-22169: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-22169 has not been moved to the MODIFIED state.

In response to this:

updating args to resolve extra reboot issue when tuned is applied

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar eggfoobar deleted the fix-realtime-gcp-tuned branch October 20, 2023 14:55
@sdodson
Copy link
Member

sdodson commented Oct 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@sdodson: Jira Issue OCPBUGS-22169: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22169 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
7 participants