add vsphere-ipi-ovn-dualstack-ipsec #44742

rbbratta · 2023-10-23T18:41:03Z

We need to test all networking features on dualstack and dualstack-primaryipv6

…psec

openshift-ci-robot · 2023-10-23T18:49:53Z

[REHEARSALNOTIFIER]
@rbbratta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-dualstack-privmaryv6-ipsec-f28-destructive	N/A	periodic	Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-vsphere-ipi-ovn-dualstack-ipsec-f28	N/A	periodic	Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-vsphere-ipi-ovn-dualstack-privmaryv6-ipsec-f28	N/A	periodic	Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-dualstack-privmaryv6-ipsec-f28	N/A	periodic	Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-dualstack-ipsec-f28-destructive	N/A	periodic	Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-vsphere-ipi-ovn-dualstack-privmaryv6-ipsec-f28-destructive	N/A	periodic	Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-vsphere-ipi-ovn-dualstack-ipsec-f28-destructive	N/A	periodic	Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-ipi-ovn-dualstack-ipsec-f28	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

rbbratta · 2023-10-23T18:51:55Z

Testing for combined SDN-3604 and OPNET-230

IPsec with DualStack.

rbbratta · 2023-10-23T18:52:38Z

/cc @anuragthehatter

rbbratta · 2023-10-23T19:46:49Z

Testing with the cluster-network-03-config.yml manifest is different than runtime IPsec enablement because CNO automatically decrements the Cluster MTU for IPsec at install time.

rbbratta · 2023-10-23T19:48:34Z

https://github.com/search?q=repo%3Aopenshift/cluster-network-operator%20getOVNEncapOverhead&type=code

anuragthehatter · 2023-10-24T17:14:37Z

Looks ok to me @rbbratta Thanks
@zhaozhanqi probably check cron values to make sure.

/lgtm

openshift-ci · 2023-10-24T17:17:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter, rbbratta
Once this PR has been reviewed and has the lgtm label, please assign liangxia for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zhaozhanqi · 2023-10-25T01:46:16Z

cron value should be generated by scripts I guess
this looks good to me
/assign @jianlinliu

jianlinliu · 2023-10-25T01:58:55Z

...t/openshift-tests-private/openshift-openshift-tests-private-release-4.14__amd64-nightly.yaml

@@ -3819,6 +3819,48 @@ tests:
    test:
    - chain: openshift-e2e-test-qe-destructive
    workflow: cucushift-installer-rehearse-vsphere-ipi-ovn-ipsec
+- as: vsphere-ipi-ovn-dualstack-ipsec-f28


Based on already have some other vsphere-ipi-ovn-dualstack and vsphere-ipi-ovn-dualstack-privmaryv6 ci jobs, can we across-cover them to save some vsphere slice quota (we only have a small number of vsphere slice quota).

E.g: non-destructive testing run on vsphere-ipi-ovn-dualstack, destructive testing run on vsphere-ipi-ovn-dualstack-ipsec.

or if we can only do base health check and do not run openshift-e2e tests on vsphere-ipi-ovn-dualstack
since vsphere-ipi-ovn-dualstack-privmaryv6-ipsec-f28 should be able to cover all tests (with or w/o ipsec cases)

I'd rather drop IPv4 only tests like vsphere-ipi-ovn-ipsec-f28. The single stack IPv4 tests are less useful.

We still have almost a whole matrix test on the Dualstacks.

ipi-ovn-shared-to-local-gw-migration

ipi-proxy-fips

ipi-proxy-workers-rhel8 (we haven't tested DualStack with RHEL workers?)

ipi-external-lb

ipi-disk-encryption-tang-fips

All these need testing on the DualStacks.

Ideally DualStack IPv4 would become the default and replace SingleStack IPv4.

#44812

It looks like we have a bunch of OpenShiftSDN tests as well, those need to be switched to OVN DualStack for 4.15

Same for Privmaryv6 #44813

I'd rather drop IPv4 only tests like vsphere-ipi-ovn-ipsec-f28

I am okay with that, beside that, I still have concern about vsphere slice quota, especially after vsphere vpn migration, any install which need a bastion (e.g: proxy and disconnected mirror) would consume 2 slice quota at least.

if we double (dualstack and dualstack-privmaryv6) all the configurations, slice quota would definitely become a bottleneck for ci testing.

@rbbratta I think we can mix all related feature with dualstack to one job. eg

ipi-ovn-dualstack-ipsec-fips
ipi-ovn-dualstack-ipsec-ipv6primary-fips
ipi-disk-encryption-tang-fips --> for this one, I'm not sure it's related to dualstack,
for RHEL worker on dualstack I think it's low priority.

How do we get more quota? DualStack is an important feature.

I think we have to send request to SPLAT team.

openshift-ci · 2023-11-16T01:02:58Z

@rbbratta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-12-16T10:13:06Z

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2023-12-31T10:23:23Z

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2024-01-15T16:20:23Z

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2024-01-15T16:30:05Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rbbratta added 6 commits October 23, 2023 14:24

add vsphere-ipi-ovn-dualstack-ipsec

fef4e9a

ci-chat-bot: cucushift-installer-rehearse-vsphere-ipi-ovn-dualstack-i…

0abf9f4

…psec

add vsphere-ipi-ovn-dualstack-ipsec-f28

a1500cd

add periodics for vsphere-ipi-ovn-dualstack-ipsec

c9cb694

add vsphere-ipi-ovn-dualstack-privmaryv6-ipse

19ec843

add periodics vsphere-ipi-ovn-dualstack-privmaryv6-ipsec

69d024a

openshift-ci bot requested review from anuragthehatter and hongkailiu October 23, 2023 18:53

openshift-ci bot assigned anuragthehatter Oct 24, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023

openshift-ci bot assigned jianlinliu Oct 25, 2023

jianlinliu reviewed Oct 25, 2023

View reviewed changes

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2023

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 31, 2023

openshift-ci bot closed this Jan 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add vsphere-ipi-ovn-dualstack-ipsec #44742

add vsphere-ipi-ovn-dualstack-ipsec #44742

rbbratta commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

rbbratta commented Oct 23, 2023 •

edited by openshift-ci bot

rbbratta commented Oct 23, 2023

rbbratta commented Oct 23, 2023

rbbratta commented Oct 23, 2023

anuragthehatter commented Oct 24, 2023

openshift-ci bot commented Oct 24, 2023

zhaozhanqi commented Oct 25, 2023

jianlinliu Oct 25, 2023 •

edited

zhaozhanqi Oct 25, 2023

rbbratta Oct 25, 2023

rbbratta Oct 25, 2023

rbbratta Oct 25, 2023

rbbratta Oct 25, 2023

jianlinliu Oct 25, 2023

zhaozhanqi Oct 25, 2023

rbbratta Oct 25, 2023

jianlinliu Oct 25, 2023 •

edited

openshift-ci bot commented Nov 16, 2023

openshift-bot commented Dec 16, 2023

openshift-bot commented Dec 31, 2023

openshift-bot commented Jan 15, 2024

openshift-ci bot commented Jan 15, 2024

add vsphere-ipi-ovn-dualstack-ipsec #44742

add vsphere-ipi-ovn-dualstack-ipsec #44742

Conversation

rbbratta commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

rbbratta commented Oct 23, 2023 • edited by openshift-ci bot

rbbratta commented Oct 23, 2023

rbbratta commented Oct 23, 2023

rbbratta commented Oct 23, 2023

anuragthehatter commented Oct 24, 2023

openshift-ci bot commented Oct 24, 2023

zhaozhanqi commented Oct 25, 2023

jianlinliu Oct 25, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jianlinliu Oct 25, 2023 • edited

Choose a reason for hiding this comment

openshift-ci bot commented Nov 16, 2023

openshift-bot commented Dec 16, 2023

openshift-bot commented Dec 31, 2023

openshift-bot commented Jan 15, 2024

openshift-ci bot commented Jan 15, 2024

rbbratta commented Oct 23, 2023 •

edited by openshift-ci bot

jianlinliu Oct 25, 2023 •

edited

jianlinliu Oct 25, 2023 •

edited