Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labels to define components in openshift/console #4526

Merged

Conversation

christianvogt
Copy link
Contributor

Adds labels for components to be used by owners-labels plugin for the openshift/console repo.

related to: https://jira.coreos.com/browse/ODC-1294
cc @spadgett

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2019
@christianvogt
Copy link
Contributor Author

@spadgett are you good with the color?

eg.
image

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Components themselves look good 👍

cluster/ci/config/prow/labels.yaml Show resolved Hide resolved
Copy link
Member

@droslean droslean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply those changes only for your repository.

@christianvogt
Copy link
Contributor Author

Updated to include labels only under the openshift/console repo.

@spadgett
Copy link
Member

/lgtm

but will need @droslean or @stevekuznetsov to approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2019
@droslean
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, droslean, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit e9301d1 into openshift:master Jul 29, 2019
@openshift-ci-robot
Copy link
Contributor

@christianvogt: Updated the labels configmap in namespace ci using the following files:

  • key labels.yaml using file cluster/ci/config/prow/labels.yaml

In response to this:

Adds labels for components to be used by owners-labels plugin for the openshift/console repo.

related to: https://jira.coreos.com/browse/ODC-1294
cc @spadgett

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants