OPRUN-3082: Remove verify-commits-shared test #45270
Conversation
The operator framework portfolio consists of a number of projects that have an upstream project. The verify-commits makefile target had been introduced in each of the downstream projects to assist with the downstreaming efforts. The commit checking logic was eventually moved into a container and was rolled out as the verify-commits-shared test, which ran alongside the verify-commits test to ensure that it worked as expected. We are now confident that the verify-commits-shared test is running as expected, and can replace the logic used in the verify-commits test with that of the verify-commits-shared test, which will allow us to remove the verify-commits Makefile targets from each of the repos, simplifying the code base and reducing duplication of code. Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
/pj-rehearse max |
|
/retest |
|
Rehearsals on verify-commits jobs will never pass because the commit they use is coming from this repo/PR, not from the target repo. /pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
@awgreene: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
awgreene
changed the title
The operator framework portfolio consists of a number of projects that have an upstream project. The verify-commits makefile target had been introduced in each of the downstream projects to assist with the downstreaming efforts. The commit checking logic was eventually moved into a container and was rolled out as the verify-commits-shared test, which ran alongside the verify-commits test to ensure that it worked as expected.
We are now confident that the verify-commits-shared test is running as expected, and can replace the logic used in the verify-commits test with that of the verify-commits-shared test, which will allow us to remove the verify-commits Makefile targets from each of the repos, simplifying the code base and reducing duplication of code.