-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARMOCP-567: AWS and Azure test configs for clusters heterogeneous in arch and kernel pagesize #45768
ARMOCP-567: AWS and Azure test configs for clusters heterogeneous in arch and kernel pagesize #45768
Conversation
@aleskandro: This pull request references ARMOCP-567 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/pj-rehearse |
Also refers MCO-800 |
/hold cc @sergiordlr for visibility. |
f736fae
to
3c693d0
Compare
/pj-rehearse |
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-azure-ipi-arm-mixarch-kerneltype-f28-day2-64k-pages |
@aleskandro: job(s): periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-azure-ipi-arm-mixarch-kerneltype-f28-day2-64k-pages either don't exist or were not found to be affected, and cannot be rehearsed |
d245d1b
to
1d52e88
Compare
/pj-rehearse |
...t/openshift-tests-private/openshift-openshift-tests-private-release-4.15__multi-nightly.yaml
Outdated
Show resolved
Hide resolved
...t/openshift-tests-private/openshift-openshift-tests-private-release-4.15__multi-nightly.yaml
Show resolved
Hide resolved
...t/openshift-tests-private/openshift-openshift-tests-private-release-4.15__multi-nightly.yaml
Outdated
Show resolved
Hide resolved
hi @lwan-wanglin thanks for the comments, going to address them and continue here. In the meantime, the azure fullypriv-disc seems permafailing at the mirror-by-oc-adm step. Do you have any info about it? Perhaps, the bastion get full in storage? |
I checked azure disconnected jobs in reportportal, no such failures, it might be a flaky, we can rebuild the job. |
1d52e88
to
1792aa5
Compare
/pj-rehearse |
1792aa5
to
1686d53
Compare
/pj-rehearse |
1686d53
to
917aa5e
Compare
/pj-rehearse |
917aa5e
to
a86ce9d
Compare
/pj-rehearse |
@aleskandro: no rehearsable tests are affected by this change |
/pj-rehearse |
/pj-rehearse |
- Do not double quote the label selector as oc would interpret it as unique - Run set_proxy() before validate_params() - Minor harmless improvements in the code style
…arch and kernel pagesize This commit adds an AWS connected and Azure disconnected test configs to run openshift-tests-private against clusters heterogeneous in CPU Architecture and kernel pagesize. The env consists of: - 3 arm64 masters - 2 arm64 workers with 4k pagesize kernel - 1 arm64 worker with 64k pagesize kernel - 1 amd64 worker (only 4k pagesize kernel is supported) Frequency is set to f28 for both the test configs. Upgrade jobs will be added once the config file from 4.15 stable to 4.15 nightly is available.
2d26c8c
to
dde502e
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/unhold Hi @sergiordlr, any objections to the added tests configs? We want to be as minimal as possible for now, so the idea is to add an AWS-connected scenario and an Azure full disconnected one. All are multi-arch and include both arm with 64k and 4k and amd64 nodes. BM tests will come later as they are partially blocked by the new infra configuration we are performing. |
/test core-valid |
1 similar comment
/test core-valid |
@aleskandro: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test core-valid |
/pj-rehearse ack |
Hello! It looks good to me. The only thing I could say is that day2 kerneltype config is not exciting the kerneltype bootstrap code, so adding a workflow to boot the cluster directly with day1 64k kernel would increase the coverage. But since we are trying to keep things minimal, imho it is acceptable to skip this scenario, especially when it is already tested via realtime kernel. /lgtm |
Yes, I did only day2 because the support for multiarch for day1 conf has not been implemented and we would avoid additional single arch configs especially for this scenario that is inherently a "heterogeneous" cluster (in kernel pagesize first). Moreover, covering the bootstrap node seems superfluous for this feature as users shouldn't need 64k pagesize kernels on bootstrap and control plane. Thanks @sergiordlr /assign @liangxia |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, liangxia, sergiordlr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit adds an AWS connected and Azure disconnected test configs to run openshift-tests-private against clusters heterogeneous in CPU Architecture and kernel pagesize.
The env consists of:
Frequency is set to f28 for both the test configs. Upgrade jobs will be added once the config file from 4.15 stable to 4.15 nightly is available.
/cc @lwan-wanglin