Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23360: change the referenced dns to avoid monitor failures #45770

Merged
merged 1 commit into from
Dec 1, 2023
Merged

OCPBUGS-23360: change the referenced dns to avoid monitor failures #45770

merged 1 commit into from
Dec 1, 2023

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Nov 16, 2023

Changes the reference DNS to be compatible with the DNS.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 16, 2023
@openshift-ci-robot
Copy link
Contributor

@prb112: This pull request references Jira Issue OCPBUGS-23360, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Changes the reference DNS to be compatible with the DNS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prb112 prb112 changed the title OCPBUGS-23360: change the referenced dns to avoid monitor failures [WIP] OCPBUGS-23360: change the referenced dns to avoid monitor failures Nov 16, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2023
@prb112
Copy link
Contributor Author

prb112 commented Nov 16, 2023

/jira refresh

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 16, 2023
@openshift-ci-robot
Copy link
Contributor

@prb112, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: failed to load registry file /tmp/git1088379507/ci-operator/step-registry/openshift/e2e/ibmcloud/heterogeneous/upi/openshift-e2e-ibmcloud-heterogeneous-upi-workflow.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field "dnsConfig"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 16, 2023
@openshift-ci-robot
Copy link
Contributor

@prb112: This pull request references Jira Issue OCPBUGS-23360, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prb112
Copy link
Contributor Author

prb112 commented Nov 16, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
Copy link
Contributor Author

prb112 commented Nov 16, 2023

@Shilpa-Gokul FYI

@prb112
Copy link
Contributor Author

prb112 commented Nov 16, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le

prb112
prb112 commented Nov 17, 2023
View reviewed changes
...nshift/e2e/ibmcloud/heterogeneous/upi/openshift-e2e-ibmcloud-heterogeneous-upi-workflow.yaml
@@ -12,6 +12,11 @@ workflow:
- chain: gather-core-dump
- ref: upi-deprovision-heterogeneous-powervs
- chain: ipi-ibmcloud-post
dnsConfig:
nameservers:
- 9.9.9.10
Copy link
Contributor Author

@prb112 prb112 Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top would be unprotected on QuadNine. This should be the first one used.

@prb112
Copy link
Contributor Author

prb112 commented Nov 17, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le

3 similar comments
@prb112
Copy link
Contributor Author

prb112 commented Nov 17, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
Copy link
Contributor Author

prb112 commented Nov 17, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
Copy link
Contributor Author

prb112 commented Nov 17, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
Copy link
Contributor Author

prb112 commented Nov 17, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

2 similar comments
@prb112
Copy link
Contributor Author

prb112 commented Nov 20, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
Copy link
Contributor Author

prb112 commented Nov 20, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112 prb112 force-pushed the OCPBUGS-23360 branch 2 times, most recently from 7c35f08 to ce0652c Compare November 21, 2023 01:13
prb112
prb112 commented Nov 21, 2023
View reviewed changes
...nshift/e2e/ibmcloud/heterogeneous/upi/openshift-e2e-ibmcloud-heterogeneous-upi-workflow.yaml Outdated
dnsConfig:
nameservers:
- 9.9.9.10
- 162.159.42.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fall back so we can pickup misses and forward directly to the ibm lbs dns

@prb112
Copy link
Contributor Author

prb112 commented Nov 21, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

4 similar comments
@prb112
Copy link
Contributor Author

prb112 commented Nov 21, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
Copy link
Contributor Author

prb112 commented Nov 21, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
Copy link
Contributor Author

prb112 commented Nov 23, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
Copy link
Contributor Author

prb112 commented Nov 27, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112
OCPBUGS-23360: change the referenced dns to avoid monitor failures
21f9b85 
Signed-off-by: Paul Bastide <pbastide@redhat.com>
@prb112
Copy link
Contributor Author

prb112 commented Nov 28, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@prb112: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.16-ocp-e2e-ibmcloud-ovn-multi-ppc64le N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023 •
edited
Loading

@prb112: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le a78178be31922668cef0bf0b90d9ee27ad256a3c link unknown /pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-ppc64le

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@prb112
Copy link
Contributor Author

prb112 commented Nov 30, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ibmcloud-ovn-multi-ppc64le

@prb112 prb112 changed the title [WIP] OCPBUGS-23360: change the referenced dns to avoid monitor failures OCPBUGS-23360: change the referenced dns to avoid monitor failures Nov 30, 2023
@prb112
Copy link
Contributor Author

prb112 commented Nov 30, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 30, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
@prb112
Copy link
Contributor Author

prb112 commented Nov 30, 2023

Hi @pkenchap please review, and if OK, mark /lgtm when you get an opportunity. Thanks, Paul

@pkenchap
Copy link
Contributor

pkenchap commented Dec 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pkenchap, prb112

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7e8e714 into openshift:master Dec 1, 2023
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@prb112: Jira Issue OCPBUGS-23360: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23360 has been moved to the MODIFIED state.

In response to this:

Changes the reference DNS to be compatible with the DNS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzy hamzy Awaiting requested review from hamzy

@tvardema tvardema Awaiting requested review from tvardema

Assignees

@pkenchap pkenchap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
3 participants
@prb112 @openshift-ci-robot @pkenchap