Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e-aws-builds to openshift-controller-manager #4592

Merged

Conversation

gabemontero
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2019
@bparees
Copy link
Contributor

bparees commented Jul 31, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1f8bb54 into openshift:master Jul 31, 2019
@openshift-ci-robot
Copy link
Contributor

@gabemontero: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-openshift-controller-manager-master.yaml using file ci-operator/config/openshift/openshift-controller-manager/openshift-openshift-controller-manager-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-openshift-controller-manager-master.yaml using file ci-operator/config/openshift/openshift-controller-manager/openshift-openshift-controller-manager-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-openshift-controller-manager-master-presubmits.yaml using file ci-operator/jobs/openshift/openshift-controller-manager/openshift-openshift-controller-manager-master-presubmits.yaml

In response to this:

/assign @bparees

@adambkaplan fyi

see openshift/openshift-controller-manager#12 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the ocm-e2e-aws-blds branch July 31, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants