Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-1937: Add presubmit scenario testing on arm #46051

Merged
merged 2 commits into from Dec 5, 2023

Conversation

pacevedom
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 27, 2023

@pacevedom: This pull request references USHIFT-1937 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 27, 2023
@openshift-ci openshift-ci bot requested review from copejon and jogeo November 27, 2023 08:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests-arm

@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-metal-periodic-test-arm pull-ci-openshift-microshift-main-microshift-metal-tests-arm

1 similar comment
@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-metal-periodic-test-arm pull-ci-openshift-microshift-main-microshift-metal-tests-arm

@pacevedom pacevedom force-pushed the USHIFT-1937 branch 2 times, most recently from bac8b34 to 58228b7 Compare November 28, 2023 08:05
@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests-arm pull-ci-openshift-microshift-main-metal-periodic-test-arm

@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests-arm

1 similar comment
@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests-arm

@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests-arm

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@pacevedom: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-main-metal-periodic-test-arm openshift/microshift presubmit Presubmit changed
pull-ci-openshift-microshift-main-microshift-metal-tests-arm openshift/microshift presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests-arm

@pacevedom
Copy link
Contributor Author

/pj-rehearse ack
/cc @ggiguash @dhellmann

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 1, 2023
@pacevedom
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-metal-periodic-test-arm

Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann
Copy link
Contributor

/lgtm
/hold

This looks OK to me. I didn't want to merge it when you weren't around, so I left a hold. Feel free to remove that when you're ready.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 7b5902f into openshift:master Dec 5, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants