Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-9925: OpenStack: stop using ramfs for cluster-api-actuator-pkg jobs #46220

Conversation

mandre
Copy link
Member

@mandre mandre commented Nov 29, 2023

The tests reboot servers and we can't use ramfs in that case.

…g jobs

The tests reboot servers and we can't use ramfs in that case.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 29, 2023
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Jira Issue OCPBUGS-9925, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The tests reboot servers and we can't use ramfs in that case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented Nov 29, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 29, 2023
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Jira Issue OCPBUGS-9925, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @eurijon

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented Nov 29, 2023

/pj-rehearse pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-openstack-operator

@mandre
Copy link
Member Author

mandre commented Nov 30, 2023

/pj-rehearse pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-openstack-operator

@mandre
Copy link
Member Author

mandre commented Nov 30, 2023

Something's wrong with the ad-hoc jobs. From what I can tell, the periodic jobs give better results, let's see:

/pj-rehearse periodic-ci-openshift-cluster-api-actuator-pkg-master-e2e-openstack-operator-periodic

@mandre
Copy link
Member Author

mandre commented Nov 30, 2023

Found what the difference was. The job run 2 different targets:

make test-e2e

vs

make test-e2e-periodic

Hence the different behavior.

It looks like test-e2e has been broken for a while (!!) on openstack and we didn't know about it.

@mandre
Copy link
Member Author

mandre commented Nov 30, 2023

/pj-rehearse periodic-ci-openshift-cluster-api-actuator-pkg-master-e2e-openstack-operator-periodic

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@mandre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-api-actuator-pkg/master/e2e-openstack-operator 669be6d link unknown /pj-rehearse pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-openstack-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member Author

mandre commented Dec 1, 2023

This patch fixes periodic jobs at least, it's safe to merge. I'm going to fix the presubmit jobs in a different commit.

This is nicer for smaller clouds, as jobs can be better distributed.
We want to know when these jobs are failing so that we can quickly
investigate.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mandre: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-actuator-pkg-release-4.14-e2e-openstack-operator openshift/cluster-api-actuator-pkg presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-actuator-pkg-release-4.11-e2e-openstack-operator openshift/cluster-api-actuator-pkg presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-actuator-pkg-release-4.13-e2e-openstack-operator openshift/cluster-api-actuator-pkg presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-actuator-pkg-release-4.12-e2e-openstack-operator openshift/cluster-api-actuator-pkg presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-actuator-pkg-release-4.15-e2e-openstack-operator openshift/cluster-api-actuator-pkg presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-actuator-pkg-release-4.16-e2e-openstack-operator openshift/cluster-api-actuator-pkg presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-openstack-operator openshift/cluster-api-actuator-pkg presubmit Ci-operator config changed
periodic-ci-openshift-cluster-api-actuator-pkg-release-4.14-e2e-openstack-operator-periodic N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-api-actuator-pkg-release-4.13-e2e-openstack-operator-periodic N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-api-actuator-pkg-master-e2e-openstack-operator-periodic N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mandre
Copy link
Member Author

mandre commented Dec 1, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 1, 2023
@mandre
Copy link
Member Author

mandre commented Dec 1, 2023

This should be good to go, as this fixes the issue with etcd. Periodics are now green. Pre-submits are still failing for a different reason.

/assign @elmiko

@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@mdbooth
Copy link
Contributor

mdbooth commented Dec 1, 2023

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mandre, mdbooth, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fb03639 into openshift:master Dec 1, 2023
18 checks passed
@openshift-ci-robot
Copy link
Contributor

@mandre: Jira Issue OCPBUGS-9925: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-9925 has been moved to the MODIFIED state.

In response to this:

The tests reboot servers and we can't use ramfs in that case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
6 participants