Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MULTIARCH-3744: Add CI job of SNO with assisted installer for Power #46560

Merged
merged 47 commits into from
Apr 11, 2024
Merged

MULTIARCH-3744: Add CI job of SNO with assisted installer for Power #46560

merged 47 commits into from
Apr 11, 2024

Conversation

cs-zhang
Copy link
Contributor

@cs-zhang cs-zhang commented Dec 7, 2023

Add CI job for install SNO with assisted installer for Power.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 7, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 7, 2023 •
edited by openshift-ci bot

@cs-zhang: This pull request references MULTIARCH-3744 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Add CI job for install SNO with assisted installer for Power.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cs-zhang
Copy link
Contributor Author

cs-zhang commented Dec 7, 2023

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-assisted-sno-power

1 similar comment
@cs-zhang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-assisted-sno-power

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
@openshift-ci-robot
Copy link
Contributor

@cs-zhang, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto master: %!w(<nil>)

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
@openshift-ci-robot
Copy link
Contributor

@cs-zhang, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cs-zhang cs-zhang closed this Dec 12, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 12, 2023
@cs-zhang cs-zhang reopened this Dec 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2023 •
edited by openshift-ci bot

@cs-zhang: This pull request references MULTIARCH-3744 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Add CI job for install SNO with assisted installer for Power.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 12, 2023
@cs-zhang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-assisted-sno-power

1 similar comment
@cs-zhang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-assisted-sno-power

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2024
@cs-zhang
Copy link
Contributor Author

cs-zhang commented Jan 4, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-assisted-sno-power

@cs-zhang
Copy link
Contributor Author

cs-zhang commented Jan 4, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-sno-power

@openshift-ci-robot
Copy link
Contributor

@cs-zhang, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 15849827dc0a21b7cf6b8d0fd9640a1af27ece92]' failed with out: fatal: reference is not a tree: 15849827dc0a21b7cf6b8d0fd9640a1af27ece92
and error exit status 128

If the problem persists, please contact Test Platform.

@cs-zhang
Copy link
Contributor Author

/cc @jaypoulz @jmguzik @dharaneeshvrd

@cs-zhang
Copy link
Contributor Author

cs-zhang commented Apr 9, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-assisted-sno-power

@openshift-ci-robot
Copy link
Contributor

@cs-zhang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@cs-zhang: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-assisted-sno-power N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-sno-power N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cs-zhang
Copy link
Contributor Author

cs-zhang commented Apr 9, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-assisted-sno-power

@openshift-ci-robot
Copy link
Contributor

@cs-zhang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cs-zhang
Copy link
Contributor Author

cs-zhang commented Apr 9, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-assisted-sno-power

@openshift-ci-robot
Copy link
Contributor

@cs-zhang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cs-zhang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-assisted-sno-power

@openshift-ci-robot
Copy link
Contributor

@cs-zhang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024 •
edited

@cs-zhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-assisted-sno-power 375bd03 link unknown /pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-assisted-sno-power

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cs-zhang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-assisted-sno-power

@openshift-ci-robot
Copy link
Contributor

@cs-zhang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jaypoulz
Copy link
Contributor

/pj-rehearse ack

@openshift-bot
Copy link
Contributor

@jaypoulz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-bot openshift-bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 10, 2024
@jaypoulz
Copy link
Contributor

/approve

@jaypoulz
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@jaypoulz
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cs-zhang, jaypoulz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@mjturek
Copy link
Contributor

mjturek commented Apr 10, 2024

AFAICT this shouldn't conflict with IPI CI

@jaypoulz
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c2848d1 into openshift:master Apr 11, 2024
19 of 20 checks passed
saifshaikh48 pushed a commit to saifshaikh48/release that referenced this pull request Apr 23, 2024
@cs-zhang @saifshaikh48
MULTIARCH-3744: Add CI job of SNO with assisted installer for Power (o…
2546fec 
…penshift#46560)

* MULTIARCH-3744 Add CI job of SNO with assisted installer for Power

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Add e2e test

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Remove qoute for TEST_TYPE.

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Fixed CLI version and function name

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Set default value for e2e when cluster_profile is not defined

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* set the default value in sno work flow, not in global single-node

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Move the default value for e2e to workflow

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Add definition for e2e variables

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Define cluster_profile for e2e test

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Fix cluster_profile define errors.

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* remove line end space.

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Add must gather call

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Fixed cp command error

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Fixed cp command error again

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Add call to patch image registry after installation

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Add TEST_SKIPS and other fixes

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Fixed the syntax error for CI check

* Fixed the syntax error for CI check

* Fixed the order of the env vars.

* Use a fast disk for SNO node

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* add set +x to disable some debugs

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>

* Update the build machine

* Remove image registry state check after patch.

* Enable image-registry patch progress check.

* Increase CPU from 0.5 to 2.0.

* Add more debug flags

* chang CPU to 1.0 and add cluster state check.

* Add more test skips and keep CPU as 2.0.

* Fix syntax for test skips.

* Remove space from line end

* Fixed skip and add get top.

* Add proxy.conf.sh for e2e VM to use

* fixed syntax error

* Setup proxy for build VMs.

* Add more test skips

* Fixed skip test syntax error

* Remove line end space

* Use a fast tier0 disk

* Set storage-type to tier0 for SNO node

* Move e2e envs to workflow

* Clean up code

---------

Signed-off-by: CS Zhang <zhangcho@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shilpa-Gokul Shilpa-Gokul Shilpa-Gokul left review comments

@jaypoulz jaypoulz jaypoulz requested changes

@jeffdyoung jeffdyoung Awaiting requested review from jeffdyoung

@dharaneeshvrd dharaneeshvrd Awaiting requested review from dharaneeshvrd

@jmguzik jmguzik Awaiting requested review from jmguzik

Assignees

@jaypoulz jaypoulz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
7 participants
@cs-zhang @openshift-ci-robot @jaypoulz @Shilpa-Gokul @openshift-bot @mjturek @openshift-merge-robot