Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOSTEDCP-1349 Prow CI workflow Enablement] Use MCE create HostedCluster on BM DualStack disconnected + agent #46835

Merged
merged 1 commit into from Jan 8, 2024
Merged

[HOSTEDCP-1349 Prow CI workflow Enablement] Use MCE create HostedCluster on BM DualStack disconnected + agent #46835

merged 1 commit into from Jan 8, 2024

Conversation

LiangquanLi930
Copy link
Member

@LiangquanLi930 LiangquanLi930 commented Dec 15, 2023 •
edited

https://issues.redhat.com/browse/HOSTEDCP-1269
Use MCE create HostedCluster on BM DualStack disconnected + agent
testjob: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/46835/rehearse-46835-periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-dualstack-conformance/1738056578952597504

[root@r640-01 ~]# oc get pod -A | grep -v "Running"
NAMESPACE                                          NAME                                                      READY   STATUS    RESTARTS      AGE
[root@r640-01 ~]# oc get node
NAME                   STATUS   ROLES    AGE   VERSION
ostest-extraworker-0   Ready    worker   45m   v1.27.8+4fab27b
ostest-extraworker-1   Ready    worker   45m   v1.27.8+4fab27b
ostest-extraworker-2   Ready    worker   45m   v1.27.8+4fab27b
[root@r640-01 ~]# oc get clusterversion version -ojsonpath="{.status.desired}" | jq
{
  "image": "virthost.ostest.test.metalkube.org:5000/localimages/local-release-image@sha256:eaec115c6b93ca0022c6d49898c1b2f95c1784fcca2d380c0423631c87bbce0e",
  "version": "4.14.0-0.ci-2023-12-21-213111"
}

@LiangquanLi930 LiangquanLi930 changed the title HyperShift: e2e-mce-agent-disconnected-dualstack-conformance [Prow CI workflow Enablement] Use MCE create HostedCluster on BM DualStack disconnected + agent Dec 20, 2023
@LiangquanLi930 LiangquanLi930 force-pushed the HOSTEDCP-1349 branch 6 times, most recently from 4b76cae to 3869f69 Compare December 21, 2023 14:25
@LiangquanLi930
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-dualstack-conformance

@LiangquanLi930
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-dualstack-conformance

1 similar comment
@LiangquanLi930
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-dualstack-conformance

@LiangquanLi930
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-dualstack-conformance

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@LiangquanLi930: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-ipv6-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-dualstack-conformance N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 22, 2023

@LiangquanLi930: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-ipv6-conformance 64070a07edd683f8d1c7f134ee96b01fc03e27ea link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-ipv6-conformance
ci/rehearse/periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-dualstack-conformance 9dfd5805ebc34a08b5a334123fa938eca1810610 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-dualstack-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LiangquanLi930 LiangquanLi930 changed the title [Prow CI workflow Enablement] Use MCE create HostedCluster on BM DualStack disconnected + agent [HOSTEDCP-1349 Prow CI workflow Enablement] Use MCE create HostedCluster on BM DualStack disconnected + agent Dec 22, 2023
jparrill
jparrill reviewed Jan 8, 2024
View reviewed changes
ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.14-periodics.yaml
ci-operator.openshift.io/variant: periodics
ci.openshift.io/generator: prowgen
job-release: "4.14"
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-conformance
name: periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-ipv6-conformance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all of these ipv6 references to be something like dual? (if this is just the name it's fine, I just wondering that maybe we missed to move this from ipv6 to dual)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the references mean here? Here I just add ipv6 which is using general workflow: hypershift-mce-agent-disconnected-conformance. For dualstack, i updated the IP_STACK inside.

ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.14-periodics.yaml
@@ -106,8 +189,8 @@ periodics:
- --lease-server-credentials-file=/etc/boskos/credentials
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --secret-dir=/usr/local/e2e-agent-ovn-mce-disconnected-conformance-cluster-profile
- --target=e2e-agent-ovn-mce-disconnected-conformance
- --secret-dir=/usr/local/e2e-agent-ovn-mce-disconnected-ipv6-conformance-cluster-profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.14-periodics.yaml
@@ -124,7 +207,7 @@ periodics:
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /usr/local/e2e-agent-ovn-mce-disconnected-conformance-cluster-profile
- mountPath: /usr/local/e2e-agent-ovn-mce-disconnected-ipv6-conformance-cluster-profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.14-periodics.yaml
- --secret-dir=/usr/local/e2e-agent-ovn-mce-disconnected-conformance-cluster-profile
- --target=e2e-agent-ovn-mce-disconnected-conformance
- --secret-dir=/usr/local/e2e-agent-ovn-mce-disconnected-ipv6-conformance-cluster-profile
- --target=e2e-agent-ovn-mce-disconnected-ipv6-conformance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@jparrill
Copy link
Contributor

jparrill commented Jan 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, LiangquanLi930

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@LiangquanLi930
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 12458c2 into openshift:master Jan 8, 2024
20 checks passed
lihongyan1 pushed a commit to lihongyan1/release that referenced this pull request Jan 8, 2024
@LiangquanLi930 @lihongyan1
HyperShift: e2e-mce-agent-disconnected-dualstack-conformance (openshi…
b30213c 
…ft#46835)
@LiangquanLi930 LiangquanLi930 deleted the HOSTEDCP-1349 branch January 8, 2024 11:13
robpblake pushed a commit to robpblake/release that referenced this pull request Jan 11, 2024
@LiangquanLi930 @robpblake
HyperShift: e2e-mce-agent-disconnected-dualstack-conformance (openshi…
3163a5a 
…ft#46835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparrill jparrill jparrill left review comments

@bryan-cox bryan-cox Awaiting requested review from bryan-cox

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@jparrill jparrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
3 participants
@LiangquanLi930 @openshift-ci-robot @jparrill