-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-872: Add netobserv ci-job #46887
Conversation
@Amoghrd,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
908fc59
to
be675b1
Compare
be675b1
to
8a0c7e2
Compare
98a0726
to
a675780
Compare
/assign @jpinsonneau |
@Amoghrd: This pull request references NETOBSERV-872 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/assign @dhellmann |
Could you PTAL when you get the chance. TIA! @dhellmann @bparees @jmguzik @jupierce |
/pj-rehearse ack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in addition to my comments:
- this is adding a CI job for a new repo, it's not "adding it to cluster-bot" so please fix the PR title/commit text
- please compact/squash your commits. It's ok to keep separate commits for unrelated changes(if they really don't belong in a separate PR), or for separating generated code from manually edited code, but the commits on this PR don't seem to be structured that way, just iterative changes.
core-services/prow/02_config/netobserv/network-observability-operator/_pluginconfig.yaml
Outdated
Show resolved
Hide resolved
.../netobserv/network-observability-operator/netobserv-network-observability-operator-main.yaml
Outdated
Show resolved
Hide resolved
a675780
to
d3e68e7
Compare
d3e68e7
to
ccff2e6
Compare
@Amoghrd,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@Amoghrd,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
b0f0a09
to
cb0b4ff
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Amoghrd, jpinsonneau The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cb0b4ff
to
bf48e84
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@Amoghrd: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing in favor of #47683 |
No description provided.