Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1713:Restore Dockerfile for azure-disk operator #47498

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jan 10, 2024

This restores changes done via https://github.com/openshift/release/pull/47448/files#diff-d3c90828d0b4a3954ff9498d3c2196b600508244ece93a922fd3f8df79cc38fd

I assume we were unforunate that our changes to ocp-build-data is not merged yet. Once everything is merged, this should not happen again.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2024

@gnufied: This pull request references STOR-1713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This restores changes done via https://github.com/openshift/release/pull/47448/files#diff-d3c90828d0b4a3954ff9498d3c2196b600508244ece93a922fd3f8df79cc38fd

I assume we were unforunate that our changes to ocp-build-data is not merged yet. Once everything is merged, this should not happen again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@gnufied: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-operator-release-4.16-e2e-aws-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-aws-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-aws-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure-manual-oidc openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azurestack-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-hypershift-aws-e2e-external openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-images openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-security openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-unit openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-verify openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-verify-deps openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-aws-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-aws-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-aws-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-azure openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-azure-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-azure-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-azure-manual-oidc openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-azure-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-azurestack-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-hypershift-aws-e2e-external openshift/csi-operator presubmit Ci-operator config changed

A total of 30 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dobsonj
Copy link
Member

dobsonj commented Jan 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

@gnufied: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member Author

gnufied commented Jan 10, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 13e57fa into openshift:master Jan 10, 2024
16 checks passed
robpblake pushed a commit to robpblake/release that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants