Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1569:Update test-private test image tags #47502

Merged
merged 1 commit into from
Jan 16, 2024
Merged

STOR-1569:Update test-private test image tags #47502

merged 1 commit into from
Jan 16, 2024

Conversation

Phaow
Copy link
Contributor

@Phaow Phaow commented Jan 11, 2024 •
edited

STOR-1569: Update test-private test image tags

  • Since the master branch has already switch to sync with 4.16, we need to change the master/release-4.16 configs' the test image tag to 4.16.
  • The update will also solved the OCPQE-18848.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 11, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 11, 2024 •
edited by openshift-ci bot

@Phaow: This pull request references STOR-1569 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

STOR-1569: Update test-private test image tags

  • Since the master branch has already switch to sync with 4.16, we need to change the master/release-4.16 configs' the test image tag to 4.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Phaow: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-e2e-vsphere openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-e2e-vsphere-csi openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-e2e-vsphere-ovn-upgrade openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-e2e-vsphere-zones openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-images openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-unit openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-verify openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-verify-deps openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-e2e-vsphere openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-e2e-vsphere-csi openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-e2e-vsphere-ovn-upgrade openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-e2e-vsphere-zones openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-images openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-unit openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-verify openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-verify-deps openshift/vmware-vsphere-csi-driver-operator presubmit Ci-operator config changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-file-nfs-csi openshift/azure-file-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-manual-oidc openshift/azure-file-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-ovn-upgrade openshift/azure-file-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-file-csi-driver-master-images openshift/azure-file-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-file-csi-driver-master-unit openshift/azure-file-csi-driver presubmit Ci-operator config changed

A total of 264 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Phaow
Copy link
Contributor Author

Phaow commented Jan 11, 2024

/pj-rehearse pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi-extended

@Phaow
Copy link
Contributor Author

Phaow commented Jan 11, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-csi-extended

@Phaow
Copy link
Contributor Author

Phaow commented Jan 11, 2024

/pj-rehearse pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-e2e-vsphere-csi-extended

1 similar comment
@Phaow
Copy link
Contributor Author

Phaow commented Jan 11, 2024

/pj-rehearse pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.16-e2e-vsphere-csi-extended

@Phaow
Copy link
Contributor Author

Phaow commented Jan 11, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-csi-extended

@Phaow
Copy link
Contributor Author

Phaow commented Jan 11, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-aws-csi-extended

@Phaow
Copy link
Contributor Author

Phaow commented Jan 11, 2024

Hi @jsafrane @gnufied , could you please help take a look when you get a chance? Thanks in advance!

BTW the csi-operator presubmit jobs rehearse failed of { error occurred handling build azure-disk-csi-driver-operator-amd64: the build azure-disk-csi-driver-operator-amd64 failed after 1m47s with reason ManageDockerfileFailed: Failed to prepare the dockerfile for the build.}, do you happen to know why prepare the dockerfile failed maybe caused by some PR not merged for the azure-disk-csi-driver-operator migrate to csi-operator ?

@Phaow
Copy link
Contributor Author

Phaow commented Jan 11, 2024

/assign @jsafrane

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2024 •
edited by openshift-ci bot

@Phaow: This pull request references STOR-1569 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

STOR-1569: Update test-private test image tags

  • Since the master branch has already switch to sync with 4.16, we need to change the master/release-4.16 configs' the test image tag to 4.16.
  • The update will also solved the OCPQE-18848.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link
Contributor Author

Phaow commented Jan 16, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-aws-csi-extended

@Phaow
Copy link
Contributor Author

Phaow commented Jan 16, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-csi-extended

2 similar comments
@Phaow
Copy link
Contributor Author

Phaow commented Jan 16, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-csi-extended

@Phaow
Copy link
Contributor Author

Phaow commented Jan 16, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-csi-extended

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@jsafrane
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 41a4608 into openshift:master Jan 16, 2024
10 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@dobsonj dobsonj Awaiting requested review from dobsonj

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
3 participants
@Phaow @openshift-ci-robot @jsafrane