Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UPI installation on s390x with additional heterogeneous x86 nodes #48112

Merged
merged 1 commit into from Feb 27, 2024

Conversation

werled
Copy link
Contributor

@werled werled commented Jan 26, 2024

This commit adds a remote libvirt UPI installation that installas a
multi-architecture compute cluster on s390x and x86 and runs e2e tests
against the resulting cluster. This is needed for
https://issues.redhat.com/browse/MIXEDARCH-357.

The commit also changes openshift-e2e-libvirt-test to run the tests also
against the new cluster profile libvirt-s390x-amd64.

The current implementation uses a static setup for exactly one cluster.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

@werled, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: upi-install-heterogeneous-libvirt: `commands` is required
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

@werled: job(s): periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x-heterogeneous either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

@werled, pj-rehearse: unable to set up jobs ERROR:

failed resolve ReleaseBuildConfiguration: Failed resolve MultiStageTestConfiguration: [test/ocp-e2e-ovn-remote-libvirt-s390x: workflow/openshift-e2e-libvirt-upi-heterogeneous: parameter "ADDITIONAL_WORKER_ARCHITECTURE" is overridden in [test/ocp-e2e-ovn-remote-libvirt-s390x] but not declared in any step, test/ocp-e2e-ovn-remote-libvirt-s390x: workflow/openshift-e2e-libvirt-upi-heterogeneous: parameter "TEST_TYPE" is overridden in [test/ocp-e2e-ovn-remote-libvirt-s390x] but not declared in any step]

If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

@werled, pj-rehearse: unable to set up jobs ERROR:

failed resolve ReleaseBuildConfiguration: Failed resolve MultiStageTestConfiguration: [test/ocp-e2e-ovn-remote-libvirt-s390x: workflow/openshift-e2e-libvirt-upi-heterogeneous: parameter "TEST_TYPE" is overridden in [test/ocp-e2e-ovn-remote-libvirt-s390x] but not declared in any step, test/ocp-e2e-ovn-remote-libvirt-s390x: workflow/openshift-e2e-libvirt-upi-heterogeneous: parameter "ADDITIONAL_WORKER_ARCHITECTURE" is overridden in [test/ocp-e2e-ovn-remote-libvirt-s390x] but not declared in any step]

If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

@werled, pj-rehearse: unable to set up jobs ERROR:

failed resolve ReleaseBuildConfiguration: Failed resolve MultiStageTestConfiguration: test/ocp-e2e-ovn-remote-libvirt-s390x: workflow/openshift-e2e-libvirt-upi-heterogeneous: parameter "TEST_TYPE" is overridden in [test/ocp-e2e-ovn-remote-libvirt-s390x] but not declared in any step

If the problem persists, please contact Test Platform.

@werled werled force-pushed the upi-s390x branch 10 times, most recently from e86c19b to b697dbf Compare January 29, 2024 11:14
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 29, 2024
@werled werled force-pushed the upi-s390x branch 2 times, most recently from b11c7b1 to af503d3 Compare January 29, 2024 11:55
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@werled
Copy link
Contributor Author

werled commented Feb 27, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x-heterogeneous

@werled
Copy link
Contributor Author

werled commented Feb 27, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x

@werled werled force-pushed the upi-s390x branch 2 times, most recently from b323043 to 5a8b124 Compare February 27, 2024 14:35
This commit adds a remote libvirt UPI installation that installas a
multi-architecture compute cluster on s390x and x86 and runs e2e tests
against the resulting cluster. This is needed for
https://issues.redhat.com/browse/MIXEDARCH-357.

The commit also changes openshift-e2e-libvirt-test to run the tests also
against the new cluster profile libvirt-s390x-amd64.

The current implementation uses a static setup for exactly one cluster.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@werled: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-master-nightly-4.10-ocp-e2e-serial-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-compact-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.12-upgrade-from-nightly-4.11-ocp-ovn-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-compact-ovn-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-jenkins-e2e-ovn-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.16-ocp-e2e-ovn-ppc64le-powervs-original N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ovn-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-jenkins-e2e-ovn-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.16-ocp-heavy-build-ovn-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.8-ocp-e2e-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.13-upgrade-from-nightly-4.12-ocp-ovn-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.14-upgrade-from-nightly-4.13-ocp-ovn-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.8-ocp-e2e-serial-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.9-upgrade-from-nightly-4.8-ocp-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.13-ocp-image-ecosystem-ovn-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-heavy-build-ovn-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-heavy-build-ovn-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.10-ocp-e2e-compact-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-jenkins-e2e-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-image-ecosystem-ovn-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.13-upgrade-from-nightly-4.12-ocp-ovn-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.10-ocp-jenkins-e2e-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.8-ocp-image-ecosystem-remote-libvirt-s390x N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-serial-ovn-remote-libvirt-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-serial-ovn-remote-libvirt-s390x N/A periodic Registry content changed

A total of 133 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@werled
Copy link
Contributor Author

werled commented Feb 27, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x-heterogeneous

@werled
Copy link
Contributor Author

werled commented Feb 27, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x

@werled
Copy link
Contributor Author

werled commented Feb 27, 2024

/uncc @deads2k

@openshift-ci openshift-ci bot removed the request for review from deads2k February 27, 2024 15:48
@tvardema
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bear-redhat, tvardema, vrutkovs, werled

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@werled
Copy link
Contributor Author

werled commented Feb 27, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x-heterogeneous

@werled
Copy link
Contributor Author

werled commented Feb 27, 2024

The existing remote libvirt e2e test runs are not impacted by the changes I introduced to make the test also run with the cluster-profile value for the heterogeneous job.

There are currently two things still failing for the heterogeneous rehearsal (and also past rehearsals of this job), for which I've now created follow-up tasks that we'll address in follow-up PRs:

@werled
Copy link
Contributor Author

werled commented Feb 27, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 27, 2024
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

@werled: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x 61c0d7f link unknown /pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x-heterogeneous 61c0d7f link unknown /pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-ovn-remote-libvirt-s390x-heterogeneous

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b861183 into openshift:master Feb 27, 2024
22 of 24 checks passed
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

@werled: Updated the ci-secret-bootstrap configmap in namespace ci at cluster app.ci using the following files:

  • key _config.yaml using file core-services/ci-secret-bootstrap/_config.yaml

In response to this:

This commit adds a remote libvirt UPI installation that installas a
multi-architecture compute cluster on s390x and x86 and runs e2e tests
against the resulting cluster. This is needed for
https://issues.redhat.com/browse/MIXEDARCH-357.

The commit also changes openshift-e2e-libvirt-test to run the tests also
against the new cluster profile libvirt-s390x-amd64.

The current implementation uses a static setup for exactly one cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@werled werled deleted the upi-s390x branch February 27, 2024 22:15
werled added a commit to werled/openshift-release that referenced this pull request Mar 1, 2024
This adds the 4.16 version of the remote libvirt s390x + x86 cluster
installation and e2e test. The 4.15 job was introduced in:
b861183 (Remote libvirt UPI installation multi-arch compute s390x and x86 (openshift#48112), 2024-02-27)

This also removes the download of oc during the job, since it is built
and included in the image used by the refs:
openshift/installer@0f885c1

Signed-off-by: Dominik Werle <dwerle@redhat.com>
openshift-merge-bot bot pushed a commit that referenced this pull request Mar 1, 2024
This adds the 4.16 version of the remote libvirt s390x + x86 cluster
installation and e2e test. The 4.15 job was introduced in:
b861183 (Remote libvirt UPI installation multi-arch compute s390x and x86 (#48112), 2024-02-27)

This also removes the download of oc during the job, since it is built
and included in the image used by the refs:
openshift/installer@0f885c1

Signed-off-by: Dominik Werle <dwerle@redhat.com>
dis016 pushed a commit to dis016/release that referenced this pull request Mar 12, 2024
…nshift#48112)

This commit adds a remote libvirt UPI installation that installas a
multi-architecture compute cluster on s390x and x86 and runs e2e tests
against the resulting cluster. This is needed for
https://issues.redhat.com/browse/MIXEDARCH-357.

The commit also changes openshift-e2e-libvirt-test to run the tests also
against the new cluster profile libvirt-s390x-amd64.

The current implementation uses a static setup for exactly one cluster.
dis016 pushed a commit to dis016/release that referenced this pull request Mar 12, 2024
…nshift#48112)

This commit adds a remote libvirt UPI installation that installas a
multi-architecture compute cluster on s390x and x86 and runs e2e tests
against the resulting cluster. This is needed for
https://issues.redhat.com/browse/MIXEDARCH-357.

The commit also changes openshift-e2e-libvirt-test to run the tests also
against the new cluster profile libvirt-s390x-amd64.

The current implementation uses a static setup for exactly one cluster.
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
…nshift#48112)

This commit adds a remote libvirt UPI installation that installas a
multi-architecture compute cluster on s390x and x86 and runs e2e tests
against the resulting cluster. This is needed for
https://issues.redhat.com/browse/MIXEDARCH-357.

The commit also changes openshift-e2e-libvirt-test to run the tests also
against the new cluster profile libvirt-s390x-amd64.

The current implementation uses a static setup for exactly one cluster.
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
…shift#49416)

This adds the 4.16 version of the remote libvirt s390x + x86 cluster
installation and e2e test. The 4.15 job was introduced in:
b861183 (Remote libvirt UPI installation multi-arch compute s390x and x86 (openshift#48112), 2024-02-27)

This also removes the download of oc during the job, since it is built
and included in the image used by the refs:
openshift/installer@0f885c1

Signed-off-by: Dominik Werle <dwerle@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
6 participants