Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-3191: Add installer-etcd-artifacts image for etcd #48346

Merged
merged 1 commit into from Feb 19, 2024
Merged

CORS-3191: Add installer-etcd-artifacts image for etcd #48346

merged 1 commit into from Feb 19, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Feb 1, 2024

This is opened to enable building the installer-etcd-artifacts image for etcd, being introduced in openshift/etcd#249

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 1, 2024 •
edited by openshift-ci bot

@r4f4: This pull request references CORS-3191 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

This is opened to enable building the installer-etcd-artifacts image for etcd, being introduced in openshift/etcd#249

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@r4f4 r4f4 mentioned this pull request Feb 1, 2024
Merged
@r4f4
Copy link
Contributor Author

r4f4 commented Feb 1, 2024

/pj-rehearse pull-ci-openshift-etcd-openshift-4.16-images

@r4f4 r4f4 force-pushed the installer-etcd-artifacts-4.16 branch from 215371b to 83d7c4f Compare February 9, 2024 14:41
@r4f4 r4f4 marked this pull request as ready for review February 9, 2024 14:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2024
@r4f4 r4f4 force-pushed the installer-etcd-artifacts-4.16 branch from 83d7c4f to 09f882e Compare February 9, 2024 15:08
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4 r4f4 force-pushed the installer-etcd-artifacts-4.16 branch from 09f882e to ec1b135 Compare February 9, 2024 15:16
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Feb 9, 2024

/pj-rehearse pull-ci-openshift-etcd-openshift-4.16-images

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@Elbehery
Copy link
Contributor

@r4f4 hello ✋🏽

there is merge conflicts, can u please check that ?

@r4f4 r4f4 force-pushed the installer-etcd-artifacts-4.16 branch from ec1b135 to 194e5d6 Compare February 16, 2024 14:46
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2024
dhellmann
dhellmann reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image name looks OK. I'll leave the other changes up to your team to approve.

/approve

@r4f4
Copy link
Contributor Author

r4f4 commented Feb 16, 2024

Update: rebased to fix merge conflicts.

/pj-rehearse pull-ci-openshift-etcd-openshift-4.16-images

@r4f4
Copy link
Contributor Author

r4f4 commented Feb 16, 2024

@Elbehery I think we need openshift/etcd#251 before this merges.

@Elbehery
Copy link
Contributor

/retest-required

@r4f4 r4f4 force-pushed the installer-etcd-artifacts-4.16 branch from 194e5d6 to 60b68f8 Compare February 16, 2024 16:52
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@r4f4: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-etcd-openshift-4.16-configmap-scale openshift/etcd presubmit Ci-operator config changed
pull-ci-openshift-etcd-openshift-4.16-e2e-aws-etcd-recovery openshift/etcd presubmit Ci-operator config changed
pull-ci-openshift-etcd-openshift-4.16-e2e-aws-ovn openshift/etcd presubmit Ci-operator config changed
pull-ci-openshift-etcd-openshift-4.16-e2e-aws-ovn-serial openshift/etcd presubmit Ci-operator config changed
pull-ci-openshift-etcd-openshift-4.16-e2e-aws-ovn-upgrade openshift/etcd presubmit Ci-operator config changed
pull-ci-openshift-etcd-openshift-4.16-e2e-hypershift openshift/etcd presubmit Ci-operator config changed
pull-ci-openshift-etcd-openshift-4.16-e2e-hypershift-conformance openshift/etcd presubmit Ci-operator config changed
pull-ci-openshift-etcd-openshift-4.16-images openshift/etcd presubmit Ci-operator config changed
pull-ci-openshift-etcd-openshift-4.16-unit openshift/etcd presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4
Copy link
Contributor Author

r4f4 commented Feb 16, 2024

/pj-rehearse ci/rehearse/openshift/etcd/openshift-4.16/images

@openshift-ci-robot
Copy link
Contributor

@r4f4: job(s): ci/rehearse/openshift/etcd/openshift-4.16/images either don't exist or were not found to be affected, and cannot be rehearsed

@r4f4
Copy link
Contributor Author

r4f4 commented Feb 16, 2024

/pj-rehearse pull-ci-openshift-etcd-openshift-4.16-images

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented Feb 16, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 16, 2024
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@tjungblu
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, JoelSpeed, r4f4, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1e837f8 into openshift:master Feb 19, 2024
17 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@r4f4: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_origin_4_16 using file core-services/image-mirroring/openshift/mapping_origin_4_16

In response to this:

This is opened to enable building the installer-etcd-artifacts image for etcd, being introduced in openshift/etcd#249

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgoveas pushed a commit to sgoveas/release that referenced this pull request Feb 22, 2024
@r4f4 @sgoveas
CORS-3191: Add installer-etcd-artifacts image for etcd (openshift#48346)
6138392
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@r4f4 @memodi
CORS-3191: Add installer-etcd-artifacts image for etcd (openshift#48346)
abca8cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@Elbehery Elbehery Elbehery left review comments

@dusk125 dusk125 Awaiting requested review from dusk125

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
7 participants
@r4f4 @openshift-ci-robot @JoelSpeed @Elbehery @tjungblu @dhellmann @openshift-merge-robot