Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust azure-disk CSI driver build limits #48370

Merged

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Feb 2, 2024

The driver image build gets OOM killed with 4 GiB. Trying 6.

cc @openshift/storage

The driver image build gets OOM with 4 GiB. Trying 6.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jsafrane: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-azure-disk-csi-driver-release-4.17-e2e-azure openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-e2e-azure-csi openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-e2e-azure-csi-extended openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-e2e-azure-manual-oidc openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-e2e-azure-ovn-upgrade openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-images openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-security openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-unit openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-verify-commits openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.17-verify-deps openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-e2e-azure openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-e2e-azure-csi openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-e2e-azure-csi-extended openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-e2e-azure-manual-oidc openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-e2e-azure-ovn-upgrade openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-images openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-security openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-unit openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-verify-commits openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-master-verify-deps openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.16-e2e-azure openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.16-e2e-azure-csi openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.16-e2e-azure-csi-extended openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.16-e2e-azure-manual-oidc openshift/azure-disk-csi-driver presubmit Ci-operator config changed
pull-ci-openshift-azure-disk-csi-driver-release-4.16-e2e-azure-ovn-upgrade openshift/azure-disk-csi-driver presubmit Ci-operator config changed

A total of 30 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 2, 2024

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 2, 2024
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0770623 into openshift:master Feb 2, 2024
16 checks passed
afaranha pushed a commit to afaranha/release that referenced this pull request Feb 6, 2024
The driver image build gets OOM with 4 GiB. Trying 6.
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
The driver image build gets OOM with 4 GiB. Trying 6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants