Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-1032: Update SDN team reviewers and approvers in OWNERS file of coredns-ocp-dnsnameresolver repo #48499

Conversation

arkadeepsen
Copy link
Contributor

This PR is a follow up of #48345. This PR updates SDN team reviewers and approvers in OWNERS file of coredns-ocp-dnsnameresolver repo.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 6, 2024

@arkadeepsen: This pull request references CFE-1032 which is a valid jira issue.

In response to this:

This PR is a follow up of #48345. This PR updates SDN team reviewers and approvers in OWNERS file of coredns-ocp-dnsnameresolver repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@arkadeepsen: no rehearsable tests are affected by this change

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 6, 2024
@npinaeva
Copy link
Member

npinaeva commented Feb 6, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@arkadeepsen
Copy link
Contributor Author

/assign @npinaeva

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@alebedev87
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, arkadeepsen, npinaeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b357ed9 into openshift:master Feb 6, 2024
20 checks passed
afaranha pushed a commit to afaranha/release that referenced this pull request Feb 8, 2024
ritmun pushed a commit to ritmun/release that referenced this pull request Feb 8, 2024
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants