Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2483: Build gcr-credential-provider in CI #48557

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Feb 7, 2024

This change adds CI jobs to the cloud-provider-gcp repo to build the
rpm for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

It also promotes the rpms image to the cloud-provider-gcp-rpms image, to be included in the artifacts for openshift/kubernetes.

We don't use a 1.22/ocp-4.17 image for the 4.17 yaml yet as the image does not exist.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2024
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theobarberbany theobarberbany force-pushed the gcp-gcr-credential-provider-rpm-ci branch 5 times, most recently from 7bbd122 to 6f50a89 Compare February 7, 2024 16:27
@theobarberbany
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cloud-provider-gcp-master-images

@theobarberbany
Copy link
Contributor Author

CI Builds are working!

[root@af7ae491f208 /]# rpm -Uvh gcr-credential-provider-4.16.0-20240207T165423Z.el9.x86_64.rpm
Verifying...                          ################################# [100%]
Preparing...                          ################################# [100%]
Updating / installing...
   1:gcr-credential-provider-4.16.0-20################################# [100%]

... 

[root@af7ae491f208 /]# /usr/libexec/kubelet-image-credential-provider-plugins/gcr-credential-provider
GCP CRI authentication plugin

Usage:
  auth-provider-gcp [command]

,,,

@theobarberbany theobarberbany force-pushed the gcp-gcr-credential-provider-rpm-ci branch from 6f50a89 to 7496e7e Compare February 8, 2024 12:28
@theobarberbany theobarberbany changed the title WIP: Build gcr-credential-provider in CI OCPCLOUD-2483: Build gcr-credential-provider in CI Feb 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 8, 2024

@theobarberbany: This pull request references OCPCLOUD-2483 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 8, 2024

@theobarberbany: This pull request references OCPCLOUD-2483 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This change adds CI jobs to the cloud-provider-gcp repo to build the
rpm for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 8, 2024

@theobarberbany: This pull request references OCPCLOUD-2483 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany theobarberbany marked this pull request as ready for review February 8, 2024 16:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
@openshift-ci openshift-ci bot requested review from nrb and racheljpg February 8, 2024 16:19
@theobarberbany theobarberbany force-pushed the gcp-gcr-credential-provider-rpm-ci branch 5 times, most recently from 2d3d8ed to 1616654 Compare February 9, 2024 18:35
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 9, 2024

@theobarberbany: This pull request references OCPCLOUD-2483 which is a valid jira issue.

In response to this:

This change adds CI jobs to the cloud-provider-gcp repo to build the
rpm for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

It also promotes the rpms image to the cloud-provider-gcp-rpms image, to be included in the artifacts for openshift/kubernetes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany theobarberbany force-pushed the gcp-gcr-credential-provider-rpm-ci branch from 1616654 to 496a4f6 Compare February 9, 2024 18:36
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 12, 2024
@damdo
Copy link
Member

damdo commented Feb 12, 2024

Should we also change the *-4.16/4.17.yaml files (and regenerate)?

@theobarberbany theobarberbany force-pushed the gcp-gcr-credential-provider-rpm-ci branch from 496a4f6 to b5d52d3 Compare February 13, 2024 10:51
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 13, 2024
@damdo
Copy link
Member

damdo commented Feb 13, 2024

@theobarberbany I think you'd need to also run make jobs

@theobarberbany theobarberbany force-pushed the gcp-gcr-credential-provider-rpm-ci branch 2 times, most recently from d0def38 to 7b33250 Compare February 13, 2024 12:15
@theobarberbany
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cloud-provider-gcp-release-4.17-images

@theobarberbany
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cloud-provider-gcp-release-4.16-images

This change adds CI jobs to the cloud-provider-gcp repo to build the rpm
for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

It also promotes the rpms image to the cloud-provider-gcp-rpms image, to
be included in the artifacts for openshift/kubernetes.
@theobarberbany theobarberbany force-pushed the gcp-gcr-credential-provider-rpm-ci branch from 7b33250 to f27def0 Compare February 13, 2024 12:37
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@theobarberbany: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-provider-gcp-master-images openshift/cloud-provider-gcp presubmit Presubmit changed
pull-ci-openshift-cloud-provider-gcp-release-4.17-images openshift/cloud-provider-gcp presubmit Presubmit changed
pull-ci-openshift-cloud-provider-gcp-master-e2e-gcp-ovn openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-master-e2e-gcp-ovn-upgrade openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-master-fmt openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-master-verify-commits openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.17-e2e-gcp-ovn openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.17-e2e-gcp-ovn-upgrade openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.17-fmt openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.17-verify-commits openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.16-e2e-gcp-ovn openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.16-e2e-gcp-ovn-upgrade openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.16-fmt openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.16-images openshift/cloud-provider-gcp presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-gcp-release-4.16-verify-commits openshift/cloud-provider-gcp presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@theobarberbany
Copy link
Contributor Author

/pj-rehearse

@theobarberbany
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2024

@theobarberbany: This pull request references OCPCLOUD-2483 which is a valid jira issue.

In response to this:

This change adds CI jobs to the cloud-provider-gcp repo to build the
rpm for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

It also promotes the rpms image to the cloud-provider-gcp-rpms image, to be included in the artifacts for openshift/kubernetes.

We don't use a 1.22/ocp-4.17 image for the 4.17 yaml yet as the image does not exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@jupierce
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed, jupierce, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@theobarberbany
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 23fb92e into openshift:master Feb 14, 2024
23 checks passed
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@theobarberbany: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_origin_4_16 using file core-services/image-mirroring/openshift/mapping_origin_4_16

In response to this:

This change adds CI jobs to the cloud-provider-gcp repo to build the
rpm for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

It also promotes the rpms image to the cloud-provider-gcp-rpms image, to be included in the artifacts for openshift/kubernetes.

We don't use a 1.22/ocp-4.17 image for the 4.17 yaml yet as the image does not exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@theobarberbany: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cloud-provider-gcp/master/verify-commits 496a4f6 link unknown /pj-rehearse pull-ci-openshift-cloud-provider-gcp-master-verify-commits
ci/rehearse/openshift/cloud-provider-gcp/release-4.17/e2e-gcp-ovn 7b33250 link unknown /pj-rehearse pull-ci-openshift-cloud-provider-gcp-release-4.17-e2e-gcp-ovn
ci/build-farm/build10-dry f27def0 link true /test build10-dry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

shaior pushed a commit to natifridman/release that referenced this pull request Feb 20, 2024
This change adds CI jobs to the cloud-provider-gcp repo to build the rpm
for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

It also promotes the rpms image to the cloud-provider-gcp-rpms image, to
be included in the artifacts for openshift/kubernetes.
sgoveas pushed a commit to sgoveas/release that referenced this pull request Feb 22, 2024
This change adds CI jobs to the cloud-provider-gcp repo to build the rpm
for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

It also promotes the rpms image to the cloud-provider-gcp-rpms image, to
be included in the artifacts for openshift/kubernetes.
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
This change adds CI jobs to the cloud-provider-gcp repo to build the rpm
for the gcr-credential-provider

It uses the rpm_build_command (and script in the repo) to build the
RPMs, and serve them in a repository.

We then specify a build job that tries to pull and install the built RPM
from the previous step.

It also promotes the rpms image to the cloud-provider-gcp-rpms image, to
be included in the artifacts for openshift/kubernetes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants