NE-1492: Enable Gateway API feature gate in CI and run E2E tests #48873
Conversation
openshift-ci-robot
added
the
rehearsals-ack
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/work-in-progress
candita
force-pushed
the
NE-1492-GatewayAPICI
branch
from
5681608
to
80cc491
Compare
|
/retest-required |
openshift-ci-robot
removed
the
rehearsals-ack
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/pj-rehearse |
|
The new test ran successfully, albeit slowly, during pj-rehearse:
|
|
ci-operator-config-metadata failure shows something is out of sync. But if I run the suggestion listed at: |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
candita
force-pushed
the
NE-1492-GatewayAPICI
branch
from
80cc491
to
b48596f
Compare
|
/test ci-operator-config-metadata |
|
/pj-rehearse |
candita
force-pushed
the
NE-1492-GatewayAPICI
branch
from
b48596f
to
1de7c71
Compare
|
/pj-rehearse |
candita
force-pushed
the
NE-1492-GatewayAPICI
branch
from
1de7c71
to
b48596f
Compare
openshift-merge-robot
added
the
needs-rebase
|
@candita, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
candita
force-pushed
the
NE-1492-GatewayAPICI
branch
from
b48596f
to
aab1639
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/pj-rehearse |
|
/retest-required |
| test: | ||
| - as: test | ||
| cli: latest | ||
| commands: TEST=TestGatewayAPI;make test-e2e |
There was a problem hiding this comment.
Does this work without export?
| commands: TEST=TestGatewayAPI;make test-e2e | |
| commands: export TEST=TestGatewayAPI;make test-e2e |
There was a problem hiding this comment.
Upon further inspection, it looks like it doesn't: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/48873/rehearse-48873-pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-gatewayapi/1770169675854909440/artifacts/e2e-aws-gatewayapi/test/build-log.txt
I'll look into it.
However, I have not yet merged the test it needs to run.
There was a problem hiding this comment.
So, it does seem to be at least running according to https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/48873/rehearse-48873-pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-gatewayapi/1775666420378505216/artifacts/e2e-aws-gatewayapi/test/build-log.txt
go generate ./pkg/manifests
CGO_ENABLED=1 GO111MODULE=on GOFLAGS=-mod=vendor go test -timeout 1h -count 1 -v -tags e2e -run "TestGatewayAPI" ./test/e2e
testing: warning: no tests to run
PASS
ok github.com/openshift/cluster-ingress-operator/test/e2e 0.657s [no tests to run]
|
/assign @frobware |
| test: | ||
| - as: test | ||
| cli: latest | ||
| commands: TEST=TestGatewayAPI;make test-e2e |
There was a problem hiding this comment.
make TEST=TestGatewayAPI is generally the better option. This approach is more direct and aligns with overriding make variables for the duration of a specific make invocation. It keeps the override scoped to the make process, avoiding potential side effects on the environment and other processes that do not need to be aware of the TEST variable.
There was a problem hiding this comment.
Good point. It would be useful to explain why using an environment variable instead of a command-line argument is necessary, if it is.
There is a difference in semantics between using an environment variable and using a command-line argument—quoting the manual:
If a variable has been set with a command argument (*note Overriding
Variables: Overriding.), then ordinary assignments in the makefile are
ignored. If you want to set the variable in the makefile even though it
was set with a command argument, you can use an 'override' directive,
It isn't obvious to me why we would want an assignment in the Makefile to override the TEST=TestGatewayAPI command-line argument.
There was a problem hiding this comment.
Updated, thanks for the feedback.
candita
force-pushed
the
NE-1492-GatewayAPICI
branch
from
da07c8c
to
bff7683
Compare
openshift-ci-robot
removed
the
rehearsals-ack
candita
force-pushed
the
NE-1492-GatewayAPICI
branch
from
bff7683
to
e357eb2
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
Some temporary etcd issue?
/pj-rehearse |
|
@candita: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/pj-rehearse |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
Depends on openshift/cluster-ingress-operator#1023 |
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita, frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@frobware I was hoping to have this framework ready for when the tests go in. |
I see: % make TEST=TestGatewayAPI test-e2e
go generate ./pkg/manifests
CGO_ENABLED=1 GO111MODULE=on GOFLAGS=-mod=vendor go test -timeout 1h -count 1 -v -tags e2e -run "TestGatewayAPI" ./test/e2e
testing: warning: no tests to run
PASS
ok github.com/openshift/cluster-ingress-operator/test/e2e 2.347s [no tests to run/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/jira refresh |
|
/honk |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
Add a new test which enables the GatewayAPI feature gate and then runs the E2E tests.