Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-2484,OCPCLOUD-2481: Adds cloud-provider-{azure,gcp} rpms to artifacts #48966

Merged
merged 1 commit into from
Feb 20, 2024
Merged

OCPCLOUD-2484,OCPCLOUD-2481: Adds cloud-provider-{azure,gcp} rpms to artifacts #48966

merged 1 commit into from
Feb 20, 2024

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Feb 19, 2024 •
edited

Pulls azure and gcp credential providers into o/k artifacts to prevent breaking OKD & scos composes.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@theobarberbany theobarberbany changed the title WIP: Adds cloud-provider-{azure,gcp} rpms to artifacts OCPCLOUD-2484,OCPCLOUD-2481 WIP: Adds cloud-provider-{azure,gcp} rpms to artifacts Feb 19, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@theobarberbany theobarberbany force-pushed the artifacts-credential-provider-rpms branch from 00da1cb to 017d12f Compare February 19, 2024 16:35
@LorbusChris
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@theobarberbany theobarberbany force-pushed the artifacts-credential-provider-rpms branch from 017d12f to 18e94ce Compare February 20, 2024 09:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@theobarberbany
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-artifacts

@theobarberbany theobarberbany force-pushed the artifacts-credential-provider-rpms branch from 18e94ce to f8b9a4b Compare February 20, 2024 11:38
@theobarberbany theobarberbany changed the title OCPCLOUD-2484,OCPCLOUD-2481 WIP: Adds cloud-provider-{azure,gcp} rpms to artifacts OCPCLOUD-2484,OCPCLOUD-2481: Adds cloud-provider-{azure,gcp} rpms to artifacts Feb 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2024 •
edited by openshift-ci bot

@theobarberbany: This pull request references OCPCLOUD-2484 which is a valid jira issue.

This pull request references OCPCLOUD-2481 which is a valid jira issue.

In response to this:

Hopefully this is smooth sailing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-artifacts

@theobarberbany
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-release-4.16-images

@theobarberbany
Copy link
Contributor Author

pull-ci-openshift-kubernetes-release-4.17-images

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@theobarberbany: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-master-artifacts openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-configmap-scale openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-agnostic-ovn-cmd openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-crun-wasm openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-csi openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-disruptive openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-jenkins openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-multitenant openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2 openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-downgrade openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-upgrade openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-single-node openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-azure openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-azure-ovn-upgrade openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-gcp openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-gcp-ovn-upgrade openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-metal-ipi openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-metal-ipi-ovn-dualstack openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-metal-ipi-ovn-ipv6 openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-openstack openshift/kubernetes presubmit Ci-operator config changed

A total of 118 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@theobarberbany
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-release-4.17-images

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2024 •
edited by openshift-ci bot

@theobarberbany: This pull request references OCPCLOUD-2484 which is a valid jira issue.

This pull request references OCPCLOUD-2481 which is a valid jira issue.

In response to this:

Pulls azure and gcp credential providers into o/k artifacts to prevent breaking OKD & scos composes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

soltysh
soltysh approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, soltysh, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@theobarberbany
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2a07c9d into openshift:master Feb 20, 2024
19 checks passed
sgoveas pushed a commit to sgoveas/release that referenced this pull request Feb 22, 2024
@theobarberbany @sgoveas
Adds cloud-provider-{azure,gcp} rpms to artifacts (openshift#48966)
f64a76f
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@theobarberbany @memodi
Adds cloud-provider-{azure,gcp} rpms to artifacts (openshift#48966)
d56739b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

@LorbusChris LorbusChris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@theobarberbany @LorbusChris @openshift-ci-robot @soltysh