Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: add on-demand agent compact job #49008

Merged
merged 1 commit into from Feb 22, 2024
Merged

NO-ISSUE: add on-demand agent compact job #49008

merged 1 commit into from Feb 22, 2024

Conversation

andfasano
Copy link
Contributor

This could be useful to verify in the CI any patch potentially impacting the agent-based installer, in particular openshift/ovn-kubernetes#2077, related to https://issues.redhat.com/browse/OCPBUGS-29350

@andfasano andfasano changed the title add on-demand agent compact job OCPBUGS-29350: add on-demand agent compact job Feb 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 20, 2024
@openshift-ci-robot
Copy link
Contributor

@andfasano: This pull request references Jira Issue OCPBUGS-29350, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This could be useful to verify in the CI any patch potentially impacting the agent-based installer, in particular openshift/ovn-kubernetes#2077, related to https://issues.redhat.com/browse/OCPBUGS-29350

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano andfasano changed the title OCPBUGS-29350: add on-demand agent compact job NO-ISSUE: add on-demand agent compact job Feb 20, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 20, 2024
@openshift-ci-robot
Copy link
Contributor

@andfasano: This pull request explicitly references no jira issue.

In response to this:

This could be useful to verify in the CI any patch potentially impacting the agent-based installer, in particular openshift/ovn-kubernetes#2077, related to https://issues.redhat.com/browse/OCPBUGS-29350

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@andfasano: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor Author

cc @jluhrsen @martinkennelly

@openshift-ci openshift-ci bot requested review from abhat and trozet February 20, 2024 10:27
@zaneb
Copy link
Member

zaneb commented Feb 20, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@zaneb
Copy link
Member

zaneb commented Feb 20, 2024

We know this job will fail - that's why we want it (to see if openshift/ovn-kubernetes#2077 helps). So not much point running the rehearsal job
/pj-rehearse skip
/assign @tssurya

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 20, 2024
@martinkennelly
Copy link
Contributor

LGTM

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024
@jluhrsen
Copy link
Contributor

needs rebase , but lgtm as well

@andfasano andfasano closed this Feb 22, 2024
@andfasano andfasano force-pushed the agent-compact-job-ovn-kubernetes branch from a0a0cd5 to 26c4bc4 Compare February 22, 2024 09:19
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@andfasano andfasano reopened this Feb 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2024
@andfasano
Copy link
Contributor Author

(closed by mistake, thus reopened)

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 22, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@andfasano: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ovn-kubernetes-master-e2e-agent-compact-ipv4 openshift/ovn-kubernetes presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andfasano
Copy link
Contributor Author

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 22, 2024
r4f4
r4f4 reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@martinkennelly
Copy link
Contributor

@jluhrsen PTAL

@jcaamano
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, jcaamano, r4f4, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ba84143 into openshift:master Feb 22, 2024
17 of 18 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Simranpal pushed a commit to Simranpal/release that referenced this pull request Feb 27, 2024
@andfasano @Simranpal
add on-demand agent compact job (openshift#49008)
8e8e676
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 5, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-06-073110

memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@andfasano @memodi
add on-demand agent compact job (openshift#49008)
14c4b9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@abhat abhat Awaiting requested review from abhat

@trozet trozet Awaiting requested review from trozet

Assignees

@r4f4 r4f4

@zaneb zaneb

@tssurya tssurya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
9 participants
@andfasano @openshift-ci-robot @zaneb @martinkennelly @jluhrsen @jcaamano @openshift-merge-robot @r4f4 @tssurya