Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add networking console plugin prow config #49124

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add networking console plugin prow config #49124

merged 1 commit into from
Feb 28, 2024

Conversation

upalatucci
Copy link
Contributor

Configuration of a new console plugin

https://issues.redhat.com/browse/CONSOLE-3952

@openshift-ci-robot
Copy link
Contributor

@upalatucci, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load plugin configuration from tested revision of release repo: failed to merge config from /var/tmp/gitrepo3386532325/core-services/prow/02_config/openshift/networking-console-plugin/_pluginconfig.yaml into main config: failed to merge .external-plugins from supplemental config: found duplicate config for external-plugins.nmstate/nmstate-console-plugin
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@upalatucci, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load plugin configuration from tested revision of release repo: plugins [assign blunderbuss cat dog heart golint goose help hold jira label lgtm lifecycle override pony retitle shrug sigmention skip trigger verify-owners owners-label wip yuks] are duplicated for openshift/networking-console-plugin and openshift
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@openshift-ci-robot
Copy link
Contributor

@upalatucci, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load plugin configuration from tested revision of release repo: plugins [assign blunderbuss cat dog heart golint goose help hold jira label lgtm lifecycle override pony retitle shrug sigmention skip trigger verify-owners owners-label wip yuks] are duplicated for openshift/networking-console-plugin and openshift
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@upalatucci
Copy link
Contributor Author

/pj-rehearse

@upalatucci
Copy link
Contributor Author

/retest

1 similar comment
@upalatucci
Copy link
Contributor Author

/retest

@upalatucci upalatucci force-pushed the networking-plugin branch 3 times, most recently from 9382239 to b63dd99 Compare February 26, 2024 09:30
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@upalatucci
Copy link
Contributor Author

/pj-rehearse

@upalatucci
Copy link
Contributor Author

/retest

@upalatucci
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 26, 2024
dhellmann
dhellmann reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

The image name looks good based on our previous conversations.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 27, 2024
@upalatucci
Copy link
Contributor Author

/pj-rehearse

@upalatucci
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 27, 2024
@avivtur
Copy link
Contributor

avivtur commented Feb 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 511af69 and 2 for PR HEAD d4fc065 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 28, 2024
@upalatucci
Copy link
Contributor Author

/retest

1 similar comment
@upalatucci
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@upalatucci: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-networking-console-plugin-main-e2e openshift/networking-console-plugin presubmit Presubmit changed
pull-ci-openshift-networking-console-plugin-main-images openshift/networking-console-plugin presubmit Presubmit changed
pull-ci-openshift-networking-console-plugin-main-lint openshift/networking-console-plugin presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@upalatucci
Copy link
Contributor Author

/pj-rehearse

@upalatucci
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 28, 2024
@avivtur
Copy link
Contributor

avivtur commented Feb 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, dhellmann, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@upalatucci: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/networking-console-plugin/main/e2e-tests 38a7f28 link unknown /pj-rehearse pull-ci-openshift-networking-console-plugin-main-e2e-tests
ci/rehearse/openshift/networking-console-plugin/main/e2e 7a07354 link unknown /pj-rehearse pull-ci-openshift-networking-console-plugin-main-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 66b9bd1 into openshift:master Feb 28, 2024
22 of 23 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@upalatucci: Updated the following 3 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-networking-console-plugin-_pluginconfig.yaml using file core-services/prow/02_config/openshift/networking-console-plugin/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-networking-console-plugin-_prowconfig.yaml using file core-services/prow/02_config/openshift/networking-console-plugin/_prowconfig.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_origin_4_16 using file core-services/image-mirroring/openshift/mapping_origin_4_16

In response to this:

Configuration of a new console plugin

https://issues.redhat.com/browse/CONSOLE-3952

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@upalatucci @memodi
Add networking console plugin (openshift#49124)
20d009b
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
@upalatucci @BradLugo
Add networking console plugin (openshift#49124)
d505501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@droslean droslean Awaiting requested review from droslean

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@avivtur avivtur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
5 participants
@upalatucci @openshift-ci-robot @avivtur @dhellmann @openshift-merge-robot