Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3427: aws: custom security group: limit to 2 #50022

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Mar 19, 2024

With the Installer move to using CAPI/CAPA for provisioning, there are now 3 security groups created during install. With the limit of 5 per network interface, this leaves only 2 additional security groups.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2024

@r4f4: This pull request references CORS-3427 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

With the Installer move to using CAPI/CAPA for provisioning, there are now 3 security groups created during install. With the limit of 5 per network interface, this leaves only 2 additional security groups.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2024
With the Installer move to using CAPI/CAPA for provisioning, there are
now 3 security groups created during install. With the limit of 5 per
network interface, this leaves only 2 additional security groups.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@r4f4: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-aws-custom-security-groups openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-custom-security-groups openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-e2e-aws-custom-security-groups openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-altinfra-e2e-aws-custom-security-groups openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-e2e-aws-custom-security-groups openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-altinfra-e2e-aws-custom-security-groups openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.15-e2e-aws-custom-security-groups openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.15-altinfra-e2e-aws-custom-security-groups openshift/installer presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-usertags-custom-sg-fips-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-4.15-upgrade-from-stable-4.14-aws-ipi-usertags-custom-sg-fips-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-hcp-advanced-int-full-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-aws-ipi-usertags-custom-sg-arm-f5 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-stable-aws-ipi-usertags-custom-sg-fips-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-stable-aws-rosa-sts-hcp-private-link-stage-critical-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-rosa-sts-hcp-private-link-int-full-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-ec-aws-rosa-sts-advanced-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-rosa-sts-advanced-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-aws-ipi-usertags-custom-sg-fips-amd-f9-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-aws-ipi-usertags-custom-sg-fips-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hcp-advanced-stage-critical-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hcp-private-link-stage-critical-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-arm64-nightly-4.16-upgrade-from-stable-4.15-aws-ipi-usertags-custom-sg-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-rosa-sts-hcp-private-link-stage-full-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-master-rosacli-aws-rosa-sts-advanced-e2e-f3 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-rosa-sts-hcp-advanced-int-full-f7 N/A periodic Registry content changed

A total of 60 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 19, 2024

/pj-rehearse pull-ci-openshift-installer-master-e2e-aws-custom-security-groups pull-ci-openshift-installer-master-altinfra-e2e-aws-custom-security-groups periodic-ci-openshift-openshift-tests-private-release-4.16-arm64-ec-aws-ipi-usertags-custom-sg-f14

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 20, 2024

/pj-rehearse pull-ci-openshift-installer-master-altinfra-e2e-aws-custom-security-groups

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 20, 2024

altinfra-e2e-aws-custom-security-groups passed the machines created phase and it's failling because of an issue with shared VPCs in CAPA.

/pj-rehease ack

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 20, 2024

/assign @yunjiang29

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 20, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 20, 2024
@patrickdillon
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2d0b15c into openshift:master Mar 20, 2024
13 of 15 checks passed
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/master/altinfra-e2e-aws-custom-security-groups 1b22788 link unknown /pj-rehearse pull-ci-openshift-installer-master-altinfra-e2e-aws-custom-security-groups

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants