Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [TEST ONLY] Serverless: Use own cluster pool #50032

Closed
wants to merge 8 commits into from

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Mar 20, 2024

Testing changes from openshift-knative/hack#134

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@mgencur mgencur changed the title [WIP] Serverless: Use own cluster pool [WIP] [TEST ONLY] Serverless: Use own cluster pool Mar 20, 2024
@openshift-ci openshift-ci bot requested review from alanfx and aliok March 20, 2024 06:55
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mgencur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-serverless-operator-main-412-kitchensink-e2e-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-412-kitchensink-upgrade-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-412-mesh-e2e-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-412-mesh-upgrade-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-412-operator-e2e-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-412-test-upgrade-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-412-ui-e2e-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-412-upstream-e2e-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-412-upstream-e2e-kafka-aws-412 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-aws-ovn-images openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-azure-images openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-gcp-images openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-hypershift-images openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-images openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-kitchensink-e2e-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-kitchensink-upgrade-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-mesh-e2e-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-mesh-upgrade-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-operator-e2e-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-osd-images openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-single-node-images openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-test-upgrade-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-ui-e2e-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-upstream-e2e-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-415-upstream-e2e-kafka-aws-415 openshift-knative/serverless-operator presubmit Presubmit changed

A total of 368 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

/pj rehearse pull-ci-openshift-knative-serverless-operator-main-415-operator-e2e-aws-415

@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

/pj-rehearse pull-ci-openshift-knative-serverless-operator-main-415-operator-e2e-aws-415

@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

Hmm. Pj-rehearse doesn't react. Re-opening the PR

@mgencur mgencur closed this Mar 20, 2024
@mgencur mgencur reopened this Mar 20, 2024
@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

/pj-rehearse pull-ci-openshift-knative-serverless-operator-main-415-operator-e2e-aws-415

@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

/pj-rehearse pull-ci-openshift-knative-serverless-operator-main-412-operator-e2e-aws-412

This should spin up a new cluster

@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

/pj-rehearse pull-ci-openshift-knative-serverless-operator-main-415-operator-e2e-aws-415

Checking once again.

Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgencur
Copy link
Contributor Author

mgencur commented Mar 21, 2024

It works. Closing.

@mgencur mgencur closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
2 participants