Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build origin with go 1.21 #50075

Closed
wants to merge 1 commit into from
Closed

build origin with go 1.21 #50075

wants to merge 1 commit into from

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Mar 20, 2024 •
edited

This is going to be needed as the next bump of k8s.io/test will bring in code that imports packages introduced in go 1.21 into origin.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sanchezl: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-master-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-csi openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-disruptive openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-etcd-recovery openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-jenkins openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-multitenant openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2 openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-etcd-scaling openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-fips openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-image-registry openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-kubevirt openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-serial openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-ovn-upi openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-aws-proxy openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-azure openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-azure-ovn-etcd-scaling openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-baremetalds-kubevirt openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-master-e2e-gcp-csi openshift/origin presubmit Ci-operator config changed

A total of 52 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from sjenning and stlaz March 20, 2024 23:09
@sanchezl
Copy link
Contributor Author

/pj-rehearse auto-ack

@sanchezl
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-origin-master-e2e-aws-disruptive
/pj-rehearse pull-ci-openshift-origin-master-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
/pj-rehearse pull-ci-openshift-origin-master-e2e-aws-csi

1 similar comment
@sanchezl
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-origin-master-e2e-aws-disruptive
/pj-rehearse pull-ci-openshift-origin-master-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
/pj-rehearse pull-ci-openshift-origin-master-e2e-aws-csi

@stlaz
Copy link
Member

stlaz commented Mar 25, 2024

/lgtm
/hold
to see whether the tests go green

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanchezl, stlaz
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanchezl
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-origin-master-e2e-aws-disruptive pull-ci-openshift-origin-master-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback pull-ci-openshift-origin-master-e2e-aws-csi

@sanchezl
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 25, 2024
@sanchezl
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
soltysh
soltysh suggested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
I've already tried that and run into issues, more details in https://issues.redhat.com//browse/TRT-1515

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@sanchezl sanchezl changed the title bump origin to go 1.21 build origin with go 1.21 Mar 26, 2024
@sanchezl
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/origin/master/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 53a858a link unknown /pj-rehearse pull-ci-openshift-origin-master-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/rehearse/openshift/origin/master/e2e-aws-disruptive 53a858a link unknown /pj-rehearse pull-ci-openshift-origin-master-e2e-aws-disruptive
ci/prow/clusterimageset-validate 53a858a link true /test clusterimageset-validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl sanchezl closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh requested changes

@sjenning sjenning Awaiting requested review from sjenning

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@soltysh soltysh

@stlaz stlaz

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
5 participants
@sanchezl @openshift-ci-robot @stlaz @openshift-merge-robot @soltysh