Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRKLDS-1083: Add cli-manager-operator configurations #50413

Merged
merged 1 commit into from
Apr 2, 2024
Merged

WRKLDS-1083: Add cli-manager-operator configurations #50413

merged 1 commit into from
Apr 2, 2024

Conversation

ardaguclu
Copy link
Member

This PR adds required configuration files for cli-manager-operator.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot

@ardaguclu: This pull request references WRKLDS-1067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR adds required configuration files for cli-manager-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@openshift-ci-robot
Copy link
Contributor

@ardaguclu, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@ardaguclu
Copy link
Member Author

/label rehearsals-ack

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

@ardaguclu: The label(s) /label rehearsals-ack cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label rehearsals-ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member Author

/rehearsals-ack

@ardaguclu ardaguclu changed the title WRKLDS-1067: Add cli-manager-operator configurations WRKLDS-1083: Add cli-manager-operator configurations Apr 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot

@ardaguclu: This pull request references WRKLDS-1083 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR adds required configuration files for cli-manager-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ingvagabund
ingvagabund reviewed Apr 2, 2024
View reviewed changes
core-services/prow/02_config/openshift/cli-manager/_prowconfig.yaml Outdated
- keep-main-query-separate
- needs-rebase
repos:
- openshift/cli-manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lines are duplicates. Should not this go under core-services/prow/02_config/openshift/cli-manager-operator/_prowconfig.yaml instead as repos: ["openshift/cli-manager-operator"]?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is interesting because I didn't want to make any changes on this file but make update always modified this. I'll check that what I'm doing wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually removed duplicate and successfully ran make update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and thanks for review :)

ingvagabund
ingvagabund reviewed Apr 2, 2024
View reviewed changes
core-services/prow/02_config/openshift/cli-manager-operator/_prowconfig.yaml
@@ -0,0 +1,53 @@
tide:
queries:
- excludedBranches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to include includedBranches as e.g. in https://github.com/openshift/release/blob/master/core-services/prow/02_config/openshift/cli-manager/_prowconfig.yaml#L3-L18 here. Otherwise, PRs in main/master will not get merged automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ardaguclu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cli-manager-operator-main-e2e-aws-operator openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-main-images openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-main-security openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-main-unit openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-main-verify openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.16-e2e-aws-operator openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.16-images openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.16-security openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.16-unit openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.16-verify openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.17-e2e-aws-operator openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.17-images openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.17-security openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.17-unit openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-operator-release-4.17-verify openshift/cli-manager-operator presubmit Presubmit changed
pull-ci-openshift-cli-manager-main-e2e-aws-operator openshift/cli-manager presubmit Presubmit changed
pull-ci-openshift-cli-manager-release-4.16-e2e-aws-operator openshift/cli-manager presubmit Presubmit changed
pull-ci-openshift-cli-manager-release-4.17-e2e-aws-operator openshift/cli-manager presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ardaguclu
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 2, 2024
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5276eba into openshift:master Apr 2, 2024
20 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@ardaguclu: Updated the following 2 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-cli-manager-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cli-manager-operator/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-cli-manager-operator-_prowconfig.yaml using file core-services/prow/02_config/openshift/cli-manager-operator/_prowconfig.yaml

In response to this:

This PR adds required configuration files for cli-manager-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu ardaguclu deleted the cli-manager-operator branch April 2, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@jmguzik jmguzik Awaiting requested review from jmguzik

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@ardaguclu @openshift-ci-robot @ingvagabund @openshift-merge-robot