Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRKLDS-1067: Use base-rhel9 image and ci specific Dockerfile #50529

Merged

Conversation

ardaguclu
Copy link
Member

In order to perform e2e test for CLI Manager (either in operator and operand), we need to have an oc binary. We also need to install krew in this oc binary. Those operations make different the real Dockerfile and CI Dockerfile. That's why, this PR changes the Dockerfiles to Dockerfile.ci.

Furthermore, since we are using oc, our base images should align with the cli image, so that this PR uses base-rhel9 image as base image.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2024

@ardaguclu: This pull request references WRKLDS-1067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

In order to perform e2e test for CLI Manager (either in operator and operand), we need to have an oc binary. We also need to install krew in this oc binary. Those operations make different the real Dockerfile and CI Dockerfile. That's why, this PR changes the Dockerfiles to Dockerfile.ci.

Furthermore, since we are using oc, our base images should align with the cli image, so that this PR uses base-rhel9 image as base image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ardaguclu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cli-manager-release-4.17-e2e-aws-operator openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.17-images openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.17-security openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.17-unit openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.17-verify openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.16-e2e-aws-operator openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.16-images openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.16-security openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.16-unit openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-release-4.16-verify openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-main-e2e-aws-operator openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-main-images openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-main-security openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-main-unit openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-main-verify openshift/cli-manager presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.16-e2e-aws-operator openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.16-images openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.16-security openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.16-unit openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.16-verify openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.17-e2e-aws-operator openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.17-images openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.17-security openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.17-unit openshift/cli-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cli-manager-operator-release-4.17-verify openshift/cli-manager-operator presubmit Ci-operator config changed

A total of 30 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ardaguclu
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 3, 2024
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ae8c4f9 into openshift:master Apr 3, 2024
16 checks passed
@ardaguclu ardaguclu deleted the cli-manager-operator-cli branch April 3, 2024 09:06
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants