-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRKLDS-1067: Use base-rhel9 image and ci specific Dockerfile #50529
WRKLDS-1067: Use base-rhel9 image and ci specific Dockerfile #50529
Conversation
@ardaguclu: This pull request references WRKLDS-1067 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[REHEARSALNOTIFIER]
A total of 30 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/pj-rehearse ack |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In order to perform e2e test for CLI Manager (either in operator and operand), we need to have an
oc
binary. We also need to installkrew
in thisoc
binary. Those operations make different the real Dockerfile and CI Dockerfile. That's why, this PR changes the Dockerfiles toDockerfile.ci
.Furthermore, since we are using
oc
, our base images should align with the cli image, so that this PR uses base-rhel9 image as base image.