Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ci for openshift/cluster-policy-controller #5075

Merged
merged 2 commits into from
Sep 30, 2019
Merged

add ci for openshift/cluster-policy-controller #5075

merged 2 commits into from
Sep 30, 2019

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Sep 18, 2019 •
edited

  • copied config file from openshift-controller-manager master branch & 4.3 branch to cluster-policy-controller (there is no 4.3 branch in cluster-policy-controller), updated accordingly

  • added jobs for openshift/cluster-policy-controller

@deads2k @sanchezl

@sallyom
Copy link
Contributor Author

sallyom commented Sep 18, 2019

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2019
sallyom
sallyom commented Sep 18, 2019
View reviewed changes
...enshift/cluster-policy-controller/openshift-cluster-policy-controller-master-presubmits.yaml
@@ -66,7 +66,7 @@ presubmits:
secretName: sentry-dsn
trigger: (?m)^/test( | .* )e2e-aws,?($|\s.*)
- agent: kubernetes
always_run: false
always_run: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true or false? must've been manually updated, as this was generated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you likely want to copy the jobs/ files first and edit the repo name there, then regenerate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, got it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go for copy only config files and regenerate jobs, there shouldn't be manual edits

Copy link
Contributor Author

@sallyom sallyom Sep 25, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have any manual edits, i've copied config file from openshift-controller-manager, updated repo name, then regenerated.

@tnozicka
Copy link
Contributor

tnozicka commented Sep 19, 2019 •
edited

renamed config file for master branch & 4.3 branch:
openshift-controller-manager -> cluster-policy-controller

@sallyom I think the needs to be copy instead of rename

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Sep 20, 2019

renamed config file for master branch & 4.3 branch:
openshift-controller-manager -> cluster-policy-controller

@sallyom I think the needs to be copy instead of rename

ah I thought going forward this new repo would replace not co-exist, bc the Dockerfile info in cluster-policy-controller still indicates openshift-controller-manager : ) I'll fix that up now, restore the files.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2019
tnozicka
tnozicka reviewed Sep 23, 2019
View reviewed changes
...r/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml Outdated
openshift_installer:
cluster_profile: aws
upgrade: true
- as: e2e-aws-builds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need builds here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed, and bumped to 4.3

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Sep 24, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019
tnozicka
tnozicka approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2019 •
edited

@sallyom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-policy-controller/release-4.3/e2e-aws-builds ed4a7649bac3f461aab24113f1914a932ffcdf8c link /test pj-rehearse
ci/rehearse/openshift/cluster-policy-controller/release-4.3/unit ed4a7649bac3f461aab24113f1914a932ffcdf8c link /test pj-rehearse
ci/rehearse/openshift/cluster-policy-controller/release-4.3/verify-deps ed4a7649bac3f461aab24113f1914a932ffcdf8c link /test pj-rehearse
ci/rehearse/openshift/cluster-policy-controller/release-4.3/images ed4a7649bac3f461aab24113f1914a932ffcdf8c link /test pj-rehearse
ci/rehearse/openshift/cluster-policy-controller/release-4.3/verify ed4a7649bac3f461aab24113f1914a932ffcdf8c link /test pj-rehearse
ci/rehearse/openshift/cluster-policy-controller/release-4.3/e2e-aws ed4a7649bac3f461aab24113f1914a932ffcdf8c link /test pj-rehearse
ci/rehearse/openshift/cluster-policy-controller/release-4.3/e2e-aws-upgrade ed4a7649bac3f461aab24113f1914a932ffcdf8c link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka
Copy link
Contributor

/retest

@sallyom sallyom mentioned this pull request Sep 30, 2019
Closed
@mfojtik
Copy link
Member

mfojtik commented Sep 30, 2019

/lgtm

@droslean
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, mfojtik, sallyom, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2e88de7 into openshift:master Sep 30, 2019
@openshift-ci-robot
Copy link
Contributor

@sallyom: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-cluster-policy-controller-master.yaml using file ci-operator/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml
  • job-config-master-postsubmits configmap in namespace ci using the following files:
    • key openshift-cluster-policy-controller-master-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-cluster-policy-controller-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master-presubmits.yaml
  • config configmap in namespace ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • plugins configmap in namespace ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-cluster-policy-controller-master.yaml using file ci-operator/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml

In response to this:

  • copied config file from openshift-controller-manager master branch & 4.3 branch to cluster-policy-controller (there is no 4.3 branch in cluster-policy-controller), updated accordingly

  • added jobs for openshift/cluster-policy-controller

@deads2k @sanchezl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sallyom sallyom mentioned this pull request Oct 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@deads2k deads2k deads2k left review comments

@tnozicka tnozicka tnozicka approved these changes

@bparees bparees Awaiting requested review from bparees

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@mfojtik mfojtik

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
8 participants
@sallyom @tnozicka @openshift-ci-robot @mfojtik @droslean @stevekuznetsov @deads2k @openshift-merge-robot