New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ci for openshift/cluster-policy-controller #5075
add ci for openshift/cluster-policy-controller #5075
Conversation
/hold |
@@ -66,7 +66,7 @@ presubmits: | |||
secretName: sentry-dsn | |||
trigger: (?m)^/test( | .* )e2e-aws,?($|\s.*) | |||
- agent: kubernetes | |||
always_run: false | |||
always_run: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true or false? must've been manually updated, as this was generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you likely want to copy the jobs/
files first and edit the repo name there, then regenerate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go for copy only config files and regenerate jobs, there shouldn't be manual edits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't have any manual edits, i've copied config file from openshift-controller-manager, updated repo name, then regenerated.
1f475e7
to
9af8dc4
Compare
@sallyom I think the needs to be copy instead of rename |
9af8dc4
to
ed4a764
Compare
ah I thought going forward this new repo would replace not co-exist, bc the Dockerfile info in cluster-policy-controller still indicates |
ed4a764
to
a3cb447
Compare
openshift_installer: | ||
cluster_profile: aws | ||
upgrade: true | ||
- as: e2e-aws-builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need builds here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed, and bumped to 4.3
a3cb447
to
e7dadbe
Compare
/hold cancel |
...r/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml
Outdated
Show resolved
Hide resolved
...r/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml
Outdated
Show resolved
Hide resolved
e7dadbe
to
68d301e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, mfojtik, sallyom, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sallyom: Updated the following 6 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
copied config file from openshift-controller-manager master branch
& 4.3 branchto cluster-policy-controller (there is no 4.3 branch in cluster-policy-controller), updated accordinglyadded jobs for openshift/cluster-policy-controller
@deads2k @sanchezl